https://bugzilla.redhat.com/show_bug.cgi?id=1636111 --- Comment #5 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in libglyr See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries ---> Bogus warning. No longer needed. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ---> Fedora uses the %license macro for license files. Change %doc COPYING CHANGELOG AUTHORS to %license COPYING %doc CHANGELOG AUTHORS ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License (v3 or later)", "*No copyright* GNU Lesser General Public License (v3)", "Expat License", "Unknown or generated". 37 files have unknown license. Detailed output of licensecheck in /home/mukundan/nextcloud/open_source_contrib/pkg_reviews/1636111-glyr/licensecheck.txt ---> Multiple license situation needs to be addressed. For example, License: GPLv3+ and LGPLv3+ [!]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/glyr [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/glyr ---> Explicitly own the directory. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(qemu-ui- gtk, cups-client, efivar-libs, rsyslog, qemu-block-gluster, rpm- plugin-selinux, python3-qt5-webkit, libimagequant, giflib, libreoffice-graphicfilter, trousers, libdb-utils, xorg-x11-font-utils, OpenEXR-libs, libcom_err, libseccomp, p11-kit, libabw, gtkspell, libvirt-daemon-driver-storage-iscsi, libmodman, parted, libdvdread, perl-version, zstd, bluez-libs, libwebp, libxslt, system-config- printer-udev, perl-Encode, libverto-libev, python2-cryptography, libevdev, libgpg-error, lvm2-libs, perl-Digest-SHA, perl-Params- Classify, libsodium, libzstd, gtk-murrine-engine, python3-sqlalchemy, symlinks, python3-simplejson, libcdr, e2fsprogs-libs, pulseaudio-libs, lcms2, python3-Bottleneck, qemu-guest-agent, annobin, ntfs-3g, libxcb, libyubikey, python3-pycurl, openconnect, xcb-util-keysyms, m4, libgphoto2, xcb-util, libwmf-lite, xfce4-pulseaudio-plugin, pulseaudio-utils, perl-Sub-Identify, llvm5.0-libs, perl-PerlIO- utf8_strict, libeot, ImageMagick-c++, systemd-bootchart, uniconvertor, u2f-hidraw-policy, perl-JSON-XS, texlive-pdftex, perl-Ref-Util-XS, perl-Time-Piece, dbusmenu-qt, ncurses-libs, libidn2, ldns, thunar- volman, xorg-x11-xkb-utils, NetworkManager-openvpn, libxkbfile, hplip- libs, libwvstreams, sane-backends-drivers-cameras, python3-hawkey, libwpd, libdc1394, libvirt-daemon-driver-qemu, qemu-block-ssh, libwps, gssdp, libacl, pulseaudio-libs-glib2, policycoreutils, mcelog, libgdiplus, pptp, sane-backends-drivers-scanners, libXxf86misc, foomatic, texlive-dvips, python3-reportlab, libpath_utils, rpm-build, libvirt-daemon-driver-storage-sheepdog, libglvnd-gles, python3-audit, redhat-lsb-core, libmicrodns, freeglut, gstreamer1, python3-statsmodels, gmime30, dbus-libs, libreoffice-gtk3, libreoffice-gtk2, cairo-gobject, vim-minimal, libclastfm, gutenprint, openal-soft, usermode, xarchiver, qpdf-libs, linux-atm-libs, libedit, openssh, openssl, python3-cairo, python2-libdnf, accountsservice, isl, ImageMagick, gssproxy, mesa-libGLU, libatomic_ops, clang6.0-libs, libmpcdec, rubygem-io-console, geany, libyui-ncurses, libvirt-daemon- driver-interface, NetworkManager, libkate, liblangtag, python3-gmpy2, NetworkManager-l2tp-gnome, libdatrie, setuptool, guile, gl2ps, pcre- utf16, tree, pipewire, glusterfs-libs, gnupg, cronie-anacron, xfsprogs, authselect, libcroco, texlive-bibtex, xfce4-dict, qt5-qtsensors, NetworkManager-iodine, spice-server, NetworkManager- fortisslvpn-gnome, plymouth-plugin-label, colord-libs, aalib-libs, libcddb, totem-pl-parser, gpgmepp, gvnc, hypervfcopyd, cronie, libwnck, libexttextcat, qt5-qtquickcontrols, libuv, nettle, libcacard, elfutils, colord, libpipeline, pkcs11-helper, gtk-sharp2, network- scripts, findutils, popt, python2-xpyb, qt5-qtx11extras, libraw1394, lm_sensors, gcc-c++, python3-dbus, iproute-tc, libupnp, spice-glib, woff2, python2-numpy, libXfont, patch, sqlite-libs, lttng-ust, enchant, libXxf86dga, python2-smartcols, xdg-user-dirs-gtk, libwayland-client, pinentry-gnome3, libipt, mdadm, xl2tpd, device- mapper, python2-librepo, libXtst, irqbalance, GeoIP, perl-Class- XSAccessor, GraphicsMagick, libsigc++20, libXrandr, newt, liba52, hplip, crda, libical, sheepdog, qt5-qtdeclarative, vo-amrwbenc, libXfont2, libblockdev-loop, libmfx, libssh2, python3-pyqt5-sip, NetworkManager-adsl, open-vm-tools-desktop, xmlsec1-nss, libXcursor, nftables, lua-lpeg, procps-ng, plymouth-core-libs, telnet, openfortivpn, xorg-x11-drv-nouveau, zlib, libpeas, pam_krb5, gutenprint-cups, avahi, libselinux, ncurses-compat-libs, libassuan, expat, cups-filters, iw, userspace-rcu, wavpack, live555, setroubleshoot-server, make, python3-markupsafe, libnice, libsoup, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, ipmitool, cups- libs, libsepol, efivar, gzip, autogen-libopts, keyutils, libfdisk, libdmx, openssl-libs, corosynclib, libatasmart, ipset, x265-libs, libyui-gtk, libcaca, keybinder3, deltarpm, fuse-libs, gwenhywfar, xfce4-weather-plugin, xorg-x11-xauth, libglvnd-glx, libXrender, json- glib, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11-drv-vmware, xfce-polkit, NetworkManager-openconnect, btrfs-progs, ristretto, python3-mistune, wvdial, sni-qt, openssh-askpass, mesa-libglapi, glx- utils, qtkeychain-qt5, libquadmath, libass, wpa_supplicant, texlive- lib, ppp, libtiger, git, perl-Compress-Raw-Bzip2, jack-audio- connection-kit, mpg123-libs, opus, git-core, python3-tkinter, qalculate-gtk, libxklavier, traceroute, cyrus-sasl-plain, libblockdev- crypto, libreoffice-pdfimport, rp-pppoe, libtheora, attr, mtr, gtksourceview3, pugixml, plymouth, libcanberra-gtk3, mtdev, mailx, systemd-udev, fftw-libs-single, libXvMC, mousepad, wmctrl, python2-pillow, libXmu, capstone, libreoffice-impress, smartmontools, jasper-libs, librbd1, device-mapper-libs, xorg-x11-xinit, libogg, libffi, libGLEW, python2-hawkey, diffutils, chrony, time, mpfr, iputils, qt5-qtxmlpatterns, numactl-libs, libvirt-daemon-driver- nwfilter, gpgme, hypervvssd, xorg-x11-drv-openchrome, gcc-gfortran, libmcpp, libibverbs, gdb-headless, qemu-audio-pa, libgovirt, libqmi- utils, libmbim-utils, psacct, lame-libs, usbredir, ghostscript, libtirpc, iptables-libs, gnucash, cryptsetup-libs, bind-libs, pygobject2, ghostscript-x11, lua-posix, libinput, libpkgconf, teckit, python3-tables, gegl, qt5-qtconnectivity, libosinfo, qt5-qtsvg, libreoffice-calc, libqmi, gawk, xfce4-taskmanager, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects, hdf5, rdma-core, vte291, nextcloud-client-libs, qemu-block-iscsi, NetworkManager-strongswan- gnome, atril, brotli, filezilla, libdvbpsi, libsmbclient, python2-reportlab, libkcapi, libvdpau, compat-openssl10, opencore-amr, libnftnl, python3-wrapt, sstp-client, python3-libvirt, network- manager-applet, xcb-util-renderutil, texlive-luatex, lightdm, freetype, logrotate, libkadm5, libdnet, atril-libs, ntfsprogs, efibootmgr, libgusb, samba-common-libs, libfdt, libreswan, libpsl, python3-rpm, jimtcl, libuser, NetworkManager-libreswan, opensp, lz4-libs, graphviz, boost-date-time, tbb, libglade2, gts, pixman, xorg-x11-drv-vesa, python3-numexpr, libbluray, brltty, libstdc++, libbabeltrace, vpnc, psmisc, net-snmp-libs, xorg-x11-drv-libinput, mesa-libOSMesa, cairo, libgcc, gdisk, ilmbase, python3-zmq, xfce4-settings, poppler, pocl, djvulibre-libs, fftw-libs-double, libconfig, ModemManager, texmaker, qemu-img, qt5-qtbase-gui, xfce4-screenshooter, rtkit, orc, polkit, libuuid, faad2-libs, libarchive, libfreehand, python3-scipy, xfdesktop, cryptsetup, udisks2, clucene-contribs-lib, paps-libs, tcp_wrappers, xz, libXcomposite, rpcbind, pygtk2, python3-matplotlib-tk, harfbuzz-icu, libplist, checkpolicy, xdg-user-dirs, hwloc-libs, tetex-dvipost, python3-lazy-object-proxy, gdk-pixbuf2, xscreensaver-base, gupnp, libevent, redland, python2-cccolutils, tcpdump, yubikey- personalization-gui, libblockdev, librdmacm, lua-socket, dconf, xz- libs, dbus-glib, python3-kiwisolver, libdvdnav, strongswan, libcap, libprojectM, libvirt-daemon-driver-storage-zfs, libwbclient, kmod, libvirt-daemon-driver-storage-gluster, numad, NetworkManager- fortisslvpn, xfdashboard, GraphicsMagick-c++, libthai, fakeroot, libini_config, nss-tools, iproute, python2-gpg, libsmartcols, fakeroot-libs, python3-tornado, libyui-qt-graph, libwpg, os-prober, ethtool, libfprint, systemd-libs, cpio, libknet1, texlive-xdvi, util- linux, numlockx, krb5-libs, net-tools, python3-qt5, llvm6.0-libs, libblockdev-part, libpciaccess, clucene-core, compiler-rt, NetworkManager-ssh-gnome, libxml++, NetworkManager-pptp, libetonyek, libgs, libgxps, webkit2gtk3-jsc, libpagemaker, libxkbcommon, device- mapper-multipath-libs, yajl, lockdev, cups-filters-libs, poppler- utils, lpsolve, xorg-x11-server-utils, gnupg2, libvirt-daemon-driver- storage-iscsi-direct, cracklib, libepubgen, libdnf, ruby, gnuplot- common, gnome-keyring, libdbusmenu-gtk3, libdbusmenu-gtk2, libSM, texlive-makeindex, netpbm, nm-connection-editor, qt5-qttools-libs- help, libudisks2, gstreamer1-plugins-bad-free, NetworkManager- libreswan-gnome, python3-setools, clutter, zenity, chkconfig, libgnome-keyring, hostname, iscsi-initiator-utils, gparted, librados2, libvirt-daemon-driver-storage-mpath, pam, python2-cffi, openldap, zziplib, gamin, ipcalc, SDL, speex, libvirt-daemon-driver-storage- logical, neon, rest, libsamplerate, python2-lxml, samba-libs, boost- iostreams, pakchois, lapack, zfs-fuse, libusbmuxd, perl-Unicode- Normalize, libimobiledevice, lzop, NetworkManager-wwan, polkit-pkla- compat, jbig2dec-libs, libmtp, cyrus-sasl-lib, librevenge, nspr, python3-gobject-base, zvbi, dnsmasq, libXfixes, libblkid, libcdio, NetworkManager-l2tp, rsync, lua-libs, pavucontrol, perl-Params-Util, authselect-libs, soundtouch, xorg-x11-drv-evdev, libpeas-gtk, libXinerama, lirc-libs, vim-enhanced, libcmis, libesmtp, acl, iodine- client, xfce4-session, gupnp-igd, vid.stab, python3-fastcache, libXxf86vm, mesa-libEGL, clang-libs, rpm-plugin-systemd-inhibit, systemd-pam, python2-libvirt, glpk, ftgl, perl-Storable, perl-Digest- MD5, lua-term, libshout, perl-Sort-Key, libvirt-daemon-driver-storage- rbd, nss-util, libsemanage, libstorj, arpack, mozjs52, systemd- container, libcomps, libaec, at, file, simple-mtpfs, libblockdev-fs, java-1.8.0-openjdk-headless, libnma, gettext, soxr, python3-pandas, libutempter, libmetalink, slang, openblas-serial, usbutils, e2fsprogs, libcdio-paranoia, grub2-tools-minimal, cpp, libksba, libwayland- server, virglrenderer, dracut, gdbm, libchromaprint, osinfo-db-tools, libsndfile, libvisio, tk, ruby-libs, bzip2-libs, NetworkManager- iodine-gnome, sshpass, openssl-pkcs11, gnutls, device-mapper- persistent-data, ykpers, webkit2gtk3-plugin-process-gtk2, libselinux- utils, perl-Scalar-List-Utils, python2-appindicator, dosfstools, rng- tools, libspectre, nano, keyutils-libs, libproxy, libreoffice-math, perl-Data-Dumper, glusterfs-fuse, game-music-emu, libnfsidmap, perl- XML-Parser, mlocate, file-libs, grub2-tools, avahi-glib, mokutil, libblockdev-swap, libnetfilter_conntrack, python3-gobject, libev, xfce4-datetime-plugin, ocl-icd, fprintd-pam, blas, libXpresent, libusbx, NetworkManager-openvpn-gnome, qrencode-libs, libICE, xfce4 -places-plugin, libgexiv2, drpm, qemu-block-nfs, createrepo_c-libs, grilo, perl-Compress-Raw-Zlib, libindicator-gtk3, speexdsp, upower, p7zip, libreoffice-x11, xcb-util-wm, Thunar, atk, dbxtool, gnome-vfs2, pragha, alsa-lib, gstreamer1-plugins-good-gtk, libwnck3, x264-libs, python2-gobject, gtkmm24, libvirt-daemon-driver-storage-disk, mesa- dri-drivers, pyliblzma, libffado, suitesparse, gdbm-libs, fribidi, NetworkManager-ssh, pciutils, qt5-qttools-libs-designer, openssh- clients, blosc, texlive-mfware, libX11, mate-desktop-libs, celt051, beignet, htop, gvfs-mtp, python3-cryptography, systemd, wipe, libnl3, gimp-libs, NetworkManager-sstp, libidn, grubby, openjpeg-libs, libdbusmenu, libdbi, libbytesize, libmpeg2, qemu-block-rbd, python3-systemd, python2-libcomps, python2-pyyaml, audit-libs, gettext-libs, liborcus, qt5-qtwayland, libref_array, raptor2, gtk- update-icon-cache, libyui, plymouth-plugin-two-step, sbc, qt-x11, libsane-hpaio, bash, poppler-glib, potrace, seahorse, orage, libopenraw, lvm2, harfbuzz, cups, libva, gvfs-client, NetworkManager- libnm, python2-libs, zeromq, audit, lrzsz, libglvnd-egl, libunwind, unbound-libs, dhcp-libs, libtalloc, grep, ffmpeg, libepoxy, perl- Variable-Magic, man-db, libvirt-daemon-driver-storage-core, libibumad, epstool, mesa-libgbm, liblogging-stdlog, timedatex, fltk, qt5-qtenginio, python2-pynacl, rasqal, wireless-tools, libdb, passwd, cups-pk-helper, mono-core, kmod-libs, libdv, gutenprint-libs, lm_sensors-libs, libreoffice-writer, desktop-file-utils, libXdamage, xorg-x11-utils, bzr, libmwaw, exo, gtkmm30, clang5.0-libs, qt5-qtmultimedia, libxfce4ui, gobject-introspection, libpwquality, fontconfig, compat-ffmpeg28, jbigkit-libs, python3-sip, libkcapi- hmaccalc, libdaemon, hypervkvpd, python3-librepo, pkgconf, json-c, sed, arj, perl-threads-shared, glib-networking, NetworkManager-vpnc- gnome, python3-qt5-base, kpartx, libpng, sane-backends-libs, python3-pillow, qt5-qtwebsockets, ktoblzcheck, cyrus-sasl, hardlink, libcollection, libgcrypt, cairomm, perl-Unicode-UTF8, nss-softokn, lasi, geoclue2, lsof, binutils, libnsl2, twolame-libs, fuse-exfat, xorg-x11-server-Xorg, libmbim, perl-IO, libomp, libverto, glibmm24, gtk-xfce-engine, libXScrnSaver, realmd, libmspub, ncurses, nfs-utils, graphite2, python3-kerberos, perl-List-MoreUtils-XS, passwdqc-lib, libmad, gmp, fuse3, volume_key-libs, cdparanoia-libs, ffmpeg-libs, alsa-plugins-pulseaudio, perl-interpreter, gimp, texlive-metafont, libcurl, coreutils, gnutls-utils, libcap-ng, xfce4-screenshooter- plugin, gvfs, dbus-x11, pinentry, libvirt-daemon-driver-storage-scsi, librepo, lua-filesystem, qemu-common, gsm, gsl, boost-filesystem, libtevent, librsvg2, openblas-threads, libglvnd, boost-system, libpcap, openblas-threads64_, wxBase3, nmap, snappy, python2, libindicator, libdrm, genisoimage, rubygem-bigdecimal, pcre2, perl- TermReadKey, qt5-qtwebkit, cogl, perl-MIME-Base64, libvirt-glib, libqhull, libmspack, libssh, libmodulemd, inkscape, GConf2, glibc, xfce4-appfinder, fipscheck, bc, gtk-vnc2, quota, wget, libijs, boost- regex, qt5-qtserialport, libgomp, libexif, libvirt-daemon-driver- secret, gdk-pixbuf2-xlib, glib2, spirv-tools-libs, python2-libxml2, qemu-system-x86-core, ImageMagick-libs, libwmf, pcre2-utf16, libmnl, libzmf, libmng, nss, pcre, tcp_wrappers-libs, sane-backends, gstreamer1-plugins-base, spax, pciutils-libs, libmpc, libXi, openjpeg2, libmatroska, flac-libs, libXt, libXv, rubygem-openssl, rpm- libs, info, libnfnetlink, libiec61883, NetworkManager-sstp-gnome, rpm- sign-libs, device-mapper-event, libusal, lightdm-gtk, qt5-qtbase, libpskc, linux-atm, python3-lxml, jwhois, qemu-block-dmg, curl, yelp- libs, gnutls-dane, gnuplot, rubygem-json, fipscheck-lib, python2-pycurl, dos2unix, paps, libstaroffice, lzo-minilzo, geany- libgeany, gnome-keyring-pam, python3-matplotlib, gd, gc, python3-cups, libxshmfence, gstreamer1-plugins-ugly-free, atlas, unzip, vlc, gtk2, gtk3, libwayland-egl, libv4l, xfce4-session-engines, atkmm, npth, libyaml, mercurial, xcb-util-image, libfilezilla, libblockdev-mdraid, glusterfs, exiv2-libs, libebml, libunistring, gstreamer1-plugins-good, davfs2, python2-rpm, libasyncns, octave, qemu-block-curl, device- mapper-multipath, xmlsec1-openssl, pulseaudio-module-x11, python2-cairo, NetworkManager-pptp-gnome, jansson, bind-utils, garcon, pxz, firefox, trousers-lib, qrupdate, libnumbertext, libaom, zip, webrtc-audio-processing, startup-notification, python3-psutil, babl, libqxp, pinfo, freeipmi, xfce4-panel, libqalculate, elfutils-libs, libtasn1, perl-libintl-perl, libe-book, alsa-utils, sqlite, tar, python3-netifaces, xmlsec1-gnutls, sudo, dhcp-client, fprintd, gcc, dwz, xorg-x11-drv-qxl, gcr, ebtables, libyui-qt, avahi-libs, pigz, python3-pyyaml, libappindicator-gtk3, libquvi, gvfs-archive, thunar- archive-plugin, libao, perl-libs, kbd, dbus-daemon, libreoffice-core, libphodav, libwayland-cursor, openvpn, libpaper, xvidcore, libwacom, lzo, pango, libss, libshaderc, esmtp, polkit-libs, perl-threads, perl- Params-Validate, pangomm, mesa-libxatracker, nss-sysinit, LibRaw, texlive-gsftopk, nss-mdns, python3-cffi, qtsingleapplication-qt5, at- spi2-core, libvirt-daemon-driver-network, gegl04, glibc-common, liblockfile, bind-export-libs, xmlsec1-gcrypt, owncloud-client-libs, qt5-qtlocation, python3-libxml2, libnfs, libgfortran, stoken-libs, libiscsi, texlive-kpathsea, groff-base, libusb, hdparm, hddtemp, mesa- libGL, perl-Devel-LexAlias, perl-HTML-Parser, libldb, bind-libs-lite, NetworkManager-vpnc, libmodplug, libvirt-daemon-driver-nodedev, libXres, libcanberra, grub2-tools-efi, libart_lgpl, libgudev, xorg-x11 -drv-wacom, libsrtp, perl-Package-Stash-XS, samba-client-libs, qt5-qtscript, which, boost-chrono, samba-client, libaio, lua-expat, python3-cccolutils, aqbanking, libxfce4util, qemu-ui-curses, python2-krbv, brlapi, thunderbird, createrepo_c, liboauth, lmdb-libs, xmlsec1, xfce4-power-manager, isns-utils-libs, libmypaint, libwsman1, krb5-workstation, mcpp, nmap-ncat, vlc-core, lksctp-tools, usb_modeswitch, python3-libdnf, mythes, rubygem-psych, NetworkManager- wifi, qt, libfastjson, libvorbis, lightdm-gobject, NetworkManager- openconnect-gnome, vconfig, python3-libselinux, libodfgen, xfce4-notifyd, exiv2, iptables, texlive-xetex, libestr, qt5-qtwebchannel, lua, perl-PadWalker, llvm-libs, qtlockedfile-qt5, libvirt-libs, portaudio, passwdqc, libXft, schroedinger, libattr, hyphen, gnupg2-smime, rpm, qemu-audio-oss, libxcrypt, iptstate, radvd, libplacebo, openpgm, python3-libs, libappindicator, glusterfs-cli, perl-PathTools, ipset-libs, plymouth-graphics-libs, glusterfs-client- xlators, libreoffice-pyuno, libxml2, libreoffice-ure, iscsi-initiator- utils-iscsiuio, cyrus-sasl-gssapi, xfwm4, libargon2, mesa-vulkan- drivers, libvirt-daemon, protobuf-lite, libsecret, tumbler, gtk2-engines, strongswan-charon-nm, p11-kit-trust, dcraw, libdca, fuse-sshfs, augeas-libs, libsysfs, python3-numpy, texlive-dvipng, xfce4-terminal, perl-Cpanel-JSON-XS, boost-locale, gdk- pixbuf2-modules, at-spi2-atk, xfconf, xen-libs, perl-DateTime, vim- common, python2-kerberos, less, cifs-utils, libvpx, tcl, rpm-build- libs, libnghttp2, util-linux-user, libsolv, libxkbcommon-x11, libtdb, python3-gpg, libXdmcp, libofx, perl-Socket, python2-bcrypt, aspell, libatomic, libvisual, python3, homebank, gpm-libs, minicom, unrar, dbus-tools, shared-mime-info, SDL2, webkit2gtk3, libsigsegv, keepassxc, boost-thread, perl-Devel-Caller, shadow-utils, nextcloud- client, libcgroup, libXaw, libXau, netcf-libs, libvirt-client, libspiro, dmidecode, qemu-audio-alsa, python3-libcomps, perl-Devel- CallChecker, libjpeg-turbo, spice-gtk3, fuse3-libs, libmount, spice- vdagent, xorg-x11-drv-wacom-serial-support, xorg-x11-drv-fbdev, libqb, owncloud-client, libavc1394, libtiff, python3-libsemanage, libvncserver, libnotify, ima-evm-utils, texlive-tex, ed, python2 -gobject-base, mesa-libOpenCL, grub2-tools-extra, qemu-audio-sdl, openssh-server, fluidsynth-libs, qscintilla-qt5, taglib, libXext, libblockdev-utils, ModemManager-glib, bridge-utils, device-mapper- event-libs, initscripts, hunspell, libieee1284, wxGTK3, libndp, pulseaudio, qemu-ui-sdl, bzip2, elfutils-libelf, nss-softokn-freebl, open-vm-tools, python3-smartcols, libavdevice, libtool-ltdl, readline, yelp, xorg-x11-drv-intel, vulkan-loader, libXpm, python3-scandir), /usr/lib/.build-id/1c(libuser, qt5-qtdeclarative, gstreamer1-plugins- bad-free, ImageMagick-libs, graphviz, gstreamer1, libreoffice-core, corosynclib, glibc, gegl, gettext, qt5-qtscript, libnl3, libgphoto2, vlc-core, libICE, aqbanking, brltty, gdbm-libs, device-mapper- multipath-libs, gnupg, python3-numpy, cdparanoia-libs), /usr/lib /.build-id/b5(procps-ng, libndp, perl-interpreter, qemu- system-x86-core, wpa_supplicant, kbd, libblockdev, gettext-libs, gimp, libpwquality, glibc, coreutils, libosinfo, ruby-libs, policycoreutils, iptables, python2-appindicator, ModemManager, ImageMagick-libs, sane- backends-drivers-scanners, opencore-amr, vlc-core, GraphicsMagick, octave, libijs, qt5-qtwayland, pulseaudio, libcanberra-gtk3) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required ---> Modernize the spec file (separate comment) [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed ---> Modernize the spec file. [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required ---> Modernize the spec file. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libglyr , libglyr-devel [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: glyr-1.0.10-4.20180824git618c418e.fc30.x86_64.rpm libglyr-1.0.10-4.20180824git618c418e.fc30.x86_64.rpm libglyr-devel-1.0.10-4.20180824git618c418e.fc30.x86_64.rpm glyr-1.0.10-4.20180824git618c418e.fc30.src.rpm glyr.x86_64: E: explicit-lib-dependency libcurl glyr.x86_64: W: no-manual-page-for-binary glyrc libglyr.x86_64: W: spelling-error Summary(en_US) glyr -> glyph libglyr.x86_64: W: summary-not-capitalized C glyr library libglyr.x86_64: W: spelling-error %description -l en_US glyr -> glyph libglyr.x86_64: W: no-documentation libglyr-devel.x86_64: W: no-documentation glyr.src: W: invalid-url Source0: glyr-20180824git618c418e.tar.bz2 4 packages and 0 specfiles checked; 1 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory glyr.x86_64: E: explicit-lib-dependency libcurl glyr.x86_64: W: invalid-url URL: https://github.com/sahib/glyr <urlopen error [Errno -2] Name or service not known> glyr.x86_64: W: no-manual-page-for-binary glyrc libglyr-devel.x86_64: W: invalid-url URL: https://github.com/sahib/glyr <urlopen error [Errno -2] Name or service not known> libglyr-devel.x86_64: W: no-documentation libglyr.x86_64: W: spelling-error Summary(en_US) glyr -> glyph libglyr.x86_64: W: summary-not-capitalized C glyr library libglyr.x86_64: W: spelling-error %description -l en_US glyr -> glyph libglyr.x86_64: W: invalid-url URL: https://github.com/sahib/glyr <urlopen error [Errno -2] Name or service not known> libglyr.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 9 warnings. Requires -------- glyr (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcurl libglib-2.0.so.0()(64bit) libglyr libglyr.so.1()(64bit) rtld(GNU_HASH) sqlite libglyr-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libglyr libglyr.so.1()(64bit) pkgconfig(glib-2.0) pkgconfig(libcurl) pkgconfig(sqlite3) libglyr (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH) Provides -------- glyr: glyr glyr(x86-64) libglyr-devel: libglyr-devel libglyr-devel(x86-64) pkgconfig(libglyr) libglyr: libglyr libglyr(x86-64) libglyr.so.1()(64bit) Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1636111 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
