https://bugzilla.redhat.com/show_bug.cgi?id=1638824 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #12 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not needed: rm -rf $RPM_BUILD_ROOT - Not needed anymore: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig If you plan on packaging for F27 or EPEL7, use %ldconfig_scriptlets instead. - To avoid unintentional soname bump, it is now forbidden to glob the major soname vension, be more specific instead: %{_libdir}/*.so.1* - you seem to have forgotten to include the doc: %files %doc doc - Why? These are not doc: %doc kdsoap.pri kdwsdl2cpp.pri - Why are the binaries in the devel package? %{_bindir}/* - Be more specific here: %{_includedir}/* %{_libdir}/cmake/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
