https://bugzilla.redhat.com/show_bug.cgi?id=1638824 --- Comment #13 from Casper Meijn <casper@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #12) > - Not needed: > > rm -rf $RPM_BUILD_ROOT I removed this line > > - Not needed anymore: > > %post -p /sbin/ldconfig > > %postun -p /sbin/ldconfig I removed these lines > > If you plan on packaging for F27 or EPEL7, use %ldconfig_scriptlets > instead. > > - To avoid unintentional soname bump, it is now forbidden to glob the major > soname vension, be more specific instead: > > %{_libdir}/*.so.1* I added the library name and major version number > > - you seem to have forgotten to include the doc: > > %files > %doc doc I added doc directory to the package, thanks > > - Why? These are not doc: > > %doc kdsoap.pri kdwsdl2cpp.pri I primarily added these because upstream does it this way. I haven't used these myself, but I believe this is needed for including the library in some applications. What would be an appropriate path for these files? > > - Why are the binaries in the devel package? > > %{_bindir}/* The kdwsdl2cpp binary is a converter for translating WSDL files to c++ code, which can be included in an application and this code uses the kdsoap library. The binary is only useful during development. > > - Be more specific here: > > %{_includedir}/* > %{_libdir}/cmake/ I added the directory names to these. Spec URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00813018-kdsoap/kdsoap.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/caspermeijn/kdsoap/fedora-rawhide-x86_64/00813018-kdsoap/kdsoap-1.7.0-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
