https://bugzilla.redhat.com/show_bug.cgi?id=1640640 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - URL is 404, it should be https://metacpan.org/pod/Convert::Base32 - Use DESTDIR instead of PERL_INSTALL_ROOT URL and Source addresses are Ok. Source archive (SHA-256: 4ba82c167c41f455aa8284738727e4c94a2ebcb1c4ce797f6fda07245a642115) is original. Ok. Summary verified from lib/Convert/Base32.pm. Ok. Description verified from lib/Convert/Base32.pm. Ok. License verified from lib/Convert/Base32.pm and README. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-Convert-Base32.spec review-perl-Convert-Base32/results/perl-Convert-Base32-0.06-1.fc30.noarch.rpm review-perl-Convert-Base32/results/perl-Convert-Base32-0.06-1.fc30.src.rpm perl-Convert-Base32.noarch: W: invalid-url URL: https://metacpan.org/release/Convert::Base32 HTTP Error 404: Not Found perl-Convert-Base32.src: W: invalid-url URL: https://metacpan.org/release/Convert::Base32 HTTP Error 404: Not Found 2 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpm -q -lv -p perl-Convert-Base32-0.06-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 oct. 19 20:57 /usr/share/doc/perl-Convert-Base32 -rw-r--r-- 1 root root 680 avril 22 2012 /usr/share/doc/perl-Convert-Base32/Changes -rw-r--r-- 1 root root 1559 juil. 18 2001 /usr/share/doc/perl-Convert-Base32/README -rw-r--r-- 1 root root 1944 oct. 19 20:57 /usr/share/man/man3/Convert::Base32.3pm.gz drwxr-xr-x 2 root root 0 oct. 19 20:57 /usr/share/perl5/vendor_perl/Convert -rw-r--r-- 1 root root 4231 avril 22 2012 /usr/share/perl5/vendor_perl/Convert/Base32.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-Convert-Base32-0.06-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.0) 1 perl(Carp) 1 perl(Exporter) 1 perl(strict) 1 perl(Test::Exception) 1 perl(Test::More) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. → Add BR for strict, warnings, vars, Carp, Exporter $ rpm -q --provides -p perl-Convert-Base32-0.06-1.fc30.noarch.rpm perl(Convert::Base32) = 0.06 perl-Convert-Base32 = 0.06-1.fc30 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=30333649). Ok The package is in line with Fedora and Perl packaging guidelines. Resolution: Package approved. Please fix the aforementioned issue before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
