https://bugzilla.redhat.com/show_bug.cgi?id=1632243 Susi Lehtola <susi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to Robert-André Mauchin from comment #8) > > - Please don't use %url in source0. > > > Huh? Why? It is rather recommended to use %url. Where? It's not used in e.g. https://fedoraproject.org/wiki/Packaging:SourceURL and it makes the spec file harder to read. This is the first time I've ever seen the %url macro used. The savings you get from using it are marginal; it's just nicer to see the whole path. If you want to use macros, then you could also write URL: https://github.com/google/%{name} but I think you agree that this is just annoying, even though it evaluates to the same in the binary rpm. Anyway, that's more of a style issue. Package shaderc APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
