https://bugzilla.redhat.com/show_bug.cgi?id=1632243 --- Comment #8 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Susi Lehtola from comment #6) > Sorry, totally slipped my mind. Crazy week. > > - It appears upstream doesn't really do releases.. where did you see that > this is 2017.02? > It's based on the Changelog: https://github.com/google/shaderc/commit/7a23a01742b88329fb2260eda007172135ba25d4#diff-e4eb329834da3d36278b1b7d943b3bc9 > - Please don't use %url in source0. > Huh? Why? It is rather recommended to use %url. > - You should use a patch instead of > # We build with system libs, so no third_party code > sed -i -e '/third_party/d' \ > -e '/build-version/,/COMMENT/d' \ > CMakeLists.txt > since the sed command can fail silently and you could end up with > third_party code. You could also remove the third_party/ directory just to > be sure, this also gets rid of BSD licensed files. > I'll see what I can do. > - I recommend using a trailing / for directories in the %files section, as in > %{_includedir}/%{name} > Ok > - Patch1 comment is misleading > # https://github.com/google/shaderc/issues/407 > Patch1: 0001-Add-SONAME-version-to-the-library.patch > since it is not the source for the patch. Maybe you could submit it as a > merge request? > I'll do a PR. > - According to README.md there are tests, but they aren't enabled in the > package. You should add a %check phase or comment the spec why it is not > possible. > The building of tests are explicitly disabled because they don't work with our unbundling of 3rd party. See https://github.com/google/shaderc/issues/470 I'll add a comment explaining it. Spec URL: https://eclipseo.fedorapeople.org/shaderc.spec SRPM URL: https://eclipseo.fedorapeople.org/shaderc-2017.2-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
