https://bugzilla.redhat.com/show_bug.cgi?id=1632243 Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kwizart@xxxxxxxxx --- Comment #10 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> --- (In reply to Susi Lehtola from comment #9) > (In reply to Robert-André Mauchin from comment #8) > > > - Please don't use %url in source0. > > > > > Huh? Why? It is rather recommended to use %url. > > Where? It's not used in e.g. I also prefer to use %{url} (but with the braces) as Sources are often full of macros already. (and I'm using spectool --gf *.spec to fetch the sources anyway). But I'm against using %{name} everwhere as it's often harder to read. Also most of the time, the use of the %name macro is wrong because it describes the package name, not the project name. Theses are not the same in the case of a compat-foo package. Thx for the review anyway. @Robert-André I'm about to need shaderc for the libplacebo update to 0.6 I still wonder if it can be done for f29, in this case, please consider to submit an override tag once the package is introduced in f29. Thx in advance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
