[Bug 1592780] Review Request: perl-ReadonlyX - Faster facility for creating read-only scalars, arrays, hashes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1592780



--- Comment #2 from Emmanuel Seyman <emmanuel@xxxxxxxxx> ---
(In reply to Jitka Plesnikova from comment #1)
>
>       The Perl license should be probably also listed in License tag

I remember realizing this when building the package but forgot to fix it.
I've changed the License field to GPL+ or Artistic

> URL and Source0 
> FIX: Please update URL and source0 to the new location:
>      URL: https://metacpan.org/release/ReadonlyX/
>      Source0:
> https://cpan.metacpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz

Doh. Fixed.

> TODO: Please add version condition for perl(Module::Build::Tiny) >= 0.035
>       BR 'perl' could be removed, because perl binary is in perl-interpreter

Done.

> FIX: Add run-requires 'perl(Storable)' - lib/ReadonlyX.pm:96

Done.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-ReadonlyX/perl-ReadonlyX.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-ReadonlyX/perl-ReadonlyX-1.04-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/QORABEO5WQAC677VMWW5VT74O7FY75SZ/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux