https://bugzilla.redhat.com/show_bug.cgi?id=1592780 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok Description is ok All tests passed License is not clear to me. TODO: Artistic 2.0 is mention only in META.* ReadonlyX.pm, README.md and LICENSE are under Perl license (GPL+ or Artistic) The Perl license should be probably also listed in License tag URL and Source0 FIX: Please update URL and source0 to the new location: URL: https://metacpan.org/release/ReadonlyX/ Source0: https://cpan.metacpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz BuildRequires TODO: Please add version condition for perl(Module::Build::Tiny) >= 0.035 BR 'perl' could be removed, because perl binary is in perl-interpreter $ rpm -qp --requires perl-ReadonlyX-1.04-1.fc29.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(strict) 1 perl(vars) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Add run-requires 'perl(Storable)' - lib/ReadonlyX.pm:96 $ rpm -qp --provides perl-ReadonlyX-1.04-1.fc29.noarch.rpm | sort | uniq -c 1 perl(ReadonlyX) = 1.04 1 perl-ReadonlyX = 1.04-1.fc29 Binary provides are Ok. $ rpmlint ./perl-ReadonlyX* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Resolution: Not approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/E7CWIQOCPX7IAXF5I3PPKZTGVP2SS54F/
