https://bugzilla.redhat.com/show_bug.cgi?id=1592780 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > License is not clear to me. > TODO: Artistic 2.0 is mention only in META.* > ReadonlyX.pm, README.md and LICENSE are under Perl license (GPL+ or > Artistic) > The Perl license should be probably also listed in License tag -License: Artistic 2.0 +License: GPL+ or Artistic Fixed > URL and Source0 -URL: http://search.cpan.org/dist/ReadonlyX/ -Source0: http://www.cpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz +URL: https://metacpan.org/release/ReadonlyX/ +Source0: https://cpan.metacpan.org/authors/id/S/SA/SANKO/ReadonlyX-%{version}.tar.gz Fixed > > BuildRequires > TODO: Please add version condition for perl(Module::Build::Tiny) >= 0.035 > BR 'perl' could be removed, because perl binary is in perl-interpreter -BuildRequires: perl(Module::Build::Tiny) +BuildRequires: perl(Module::Build::Tiny) >= 0.035 BuildRequires: perl(strict) -BuildRequires: perl Fixed > FIX: Add run-requires 'perl(Storable)' - lib/ReadonlyX.pm:96 +Requires: perl(Storable) $ rpm -qpR perl-ReadonlyX-1.04-2.fc29.noarch.rpm | grep Storable perl(Storable) Fixed The package looks good now. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/KMZSQG76VNE4XT7E4TDQUDOTP4UEZSH6/
