https://bugzilla.redhat.com/show_bug.cgi?id=1541566 --- Comment #7 from William Moreno <williamjmorenor@xxxxxxxxx> --- Package Review ============== You are requering gobjects, is whipper a command line tool or provides a grafical user interface? If so work with upstream to include a desktop file and appdata.xml file. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python2.7/site-packages/whipper, /usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7.egg-info [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site- packages/whipper, /usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7 .egg-info Update %files to: %{python2_sitelib}/whipper-%{version}-py2.7.egg-info %{python2_sitelib}/whipper This way you own the directory and not only the lifes on it. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Requires -------- whipper (rpmlib, GLIBC filtered): /usr/bin/python2 libc.so.6()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) python2-whipper rtld(GNU_HASH) whipper-debuginfo (rpmlib, GLIBC filtered): whipper-debugsource (rpmlib, GLIBC filtered): python2-whipper (rpmlib, GLIBC filtered): cdrdao flac libcdio-paranoia pycdio pygobject2 python(abi) python2-CDDB python2-musicbrainzngs python2-mutagen python2-requests sox Provides -------- whipper: whipper whipper(x86-64) whipper-debuginfo: debuginfo(build-id) whipper-debuginfo whipper-debuginfo(x86-64) whipper-debugsource: whipper-debugsource whipper-debugsource(x86-64) python2-whipper: python-whipper python-whipper(x86-64) python2-whipper python2-whipper(x86-64) python2.7dist(whipper) python2dist(whipper) Source checksums ---------------- https://github.com/JoeLametta/whipper/archive/v0.6.0.tar.gz : CHECKSUM(SHA256) this package : c1919f1a99638e2649bf81bbb30f8a8b4509ab3e1a97b04346ba0b5c8fac12ea CHECKSUM(SHA256) upstream package : c1919f1a99638e2649bf81bbb30f8a8b4509ab3e1a97b04346ba0b5c8fac12ea -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
