https://bugzilla.redhat.com/show_bug.cgi?id=1541566 --- Comment #8 from Matthew <mruszczyk17@xxxxxxxxx> --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/mruszczyk/whipper/fedora-27-x86_64/00714229-whipper/whipper.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mruszczyk/whipper/fedora-27-x86_64/00714229-whipper/whipper-0.6.0-4.fc27.src.rpm Description: CD-DA ripper focused on accuracy over speed. Fedora Account System Username: mruszczyk (In reply to William Moreno from comment #6) > > > - Is it really necessary to split the python part into a separate library > > > package? It doesn't seem to be used as a library, only as a binary. > > > > I did this after asking a few questions in the #fedora-devel irc. They > > seemed to indicate that it was abnormal to not split python packages this > > way to make future python 3 support easier to setup. Is that incorrect? > > > > It is not common in Fedora packaging to split a python package in a %{name} > package and a python2-%{name} subpackage, the only reason to do dat is if > the python2-%{name} is a module importable and usefull without the > executable files in %{name}, but this are few bites of direference for the > user point of view. Thank you very much for the feedback. I have restructured the spec file to only generate a single binary package. (In reply to William Moreno from comment #7) > Package Review > ============== > > You are requering gobjects, is whipper a command line tool or provides a > grafical user interface? If so work with upstream to include a desktop file > and appdata.xml file. > > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/lib/python2.7/site-packages/whipper, > /usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7.egg-info > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib/python2.7/site- > packages/whipper, /usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7 > .egg-info > > Update %files to: > %{python2_sitelib}/whipper-%{version}-py2.7.egg-info > %{python2_sitelib}/whipper > > This way you own the directory and not only the lifes on it. The application is a command line tool and does not provide a graphical user interface. The gobject requirement is still in the tree for now but work is being done to eliminate it. I have adjusted the files section to properly take ownership of the directories. Please let me know if there is anything else I need to change at this time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
