[Bug 1531955] Review Request: seqan2 - C++ library of efficient algorithms and data structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1531955



--- Comment #13 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to Alec Leamas from comment #12)
> Hi!
> 
> Things begin to take shape... with issues below fix I'm ready to approve
> 
> 
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> 
> 
> Issues:
> =======
> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file LICENSE is not marked as %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

It is as GPLv3+, BSD and LGPLv3+

> - The devel package has no R: %{name}%{?_isa} = %{version}-%{release}
>   (GL reference in comment #9)

Devel sub-package does not need 'seqan'. They're independant. 

> - The scripts /usr/bin/plot.awk and /usr/bin/ps2pswLinks.gawk are
>   executable but has no shebang. Looking at them, it seems that they are
>   no scripts, should be 444 and thus live somewhere else (/usr/share?)
> 

Here i don't know how manage these files. Let me check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux