https://bugzilla.redhat.com/show_bug.cgi?id=1531955 --- Comment #12 from Alec Leamas <leamas.alec@xxxxxxxxx> --- Hi! Things begin to take shape... with issues below fix I'm ready to approve Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - License: contains a typo (and and) - According to GL referenced in comment #9, bundled code must be removed in %prep. However, the awesome font files are removed in %install instead. - The iostream header files mentioned in comment #10 are bundled, and thus needs a Provides(...). - The devel package has no R: %{name}%{?_isa} = %{version}-%{release} (GL reference in comment #9) - The scripts /usr/bin/plot.awk and /usr/bin/ps2pswLinks.gawk are executable but has no shebang. Looking at them, it seems that they are no scripts, should be 444 and thus live somewhere else (/usr/share?) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MIT/X11 (BSD like) GPL (v3 or later)", "SIL (v1.1)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* LGPL (v3)", "MIT/X11 (BSD like)", "MIT/X11 (BSD like) BSD (3 clause)", "*No copyright* CC0 (v5)", "BSL (v1.0) BSD (3 clause)", "zlib/libpng", "BSD (unspecified)", "LGPL (v3 or later)", "GPL (v3)", "*No copyright* CC0", "*No copyright* BSD (unspecified)", "BSD (3 clause)", "BSD (2 clause)", "MIT/X11 (BSD like) Apache (v2.0)", "*No copyright* BSD (3 clause)", "LGPL (v3)". 3263 files have unknown license. Detailed output of licensecheck in /home/mk/tmp/FedoraReview/1531955-seqan2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in seqan2-devel , seqan2-examples , seqan2-doc , seqan2-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. See: https://copr.fedorainfracloud.org/coprs/leamas/seqan2/ [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: seqan2-2.4.0-0.1.20180103git8a875d.fc28.x86_64.rpm seqan2-devel-2.4.0-0.1.20180103git8a875d.fc28.x86_64.rpm seqan2-examples-2.4.0-0.1.20180103git8a875d.fc28.x86_64.rpm seqan2-doc-2.4.0-0.1.20180103git8a875d.fc28.noarch.rpm seqan2-debuginfo-2.4.0-0.1.20180103git8a875d.fc28.x86_64.rpm seqan2-2.4.0-0.1.20180103git8a875d.fc28.src.rpm seqan2.x86_64: W: only-non-binary-in-usr-lib seqan2.x86_64: E: script-without-shebang /usr/bin/plot.awk seqan2.x86_64: E: script-without-shebang /usr/bin/ps2pswLinks.gawk seqan2.x86_64: W: no-manual-page-for-binary alf [ Several more no-manual-page removed] seqan2-devel.x86_64: W: invalid-license and MIT seqan2-devel.x86_64: W: only-non-binary-in-usr-lib seqan2-examples.x86_64: W: no-documentation seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/css/css /usr/share/font-awesome/css seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/fonts/fonts /usr/share/font-awesome/fonts seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/less/less /usr/share/font-awesome/less seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/scss/scss /usr/share/font-awesome/scss seqan2-debuginfo.x86_64: E: useless-provides debuginfo(build-id) seqan2.src:62: W: unversioned-explicit-provides bundled(gnulib) 6 packages and 0 specfiles checked; 3 errors, 58 warnings. Rpmlint (debuginfo) ------------------- Checking: seqan2-debuginfo-2.4.0-0.1.20180103git8a875d.fc28.x86_64.rpm seqan2-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory seqan2.x86_64: W: invalid-url URL: http://www.seqan.de/ <urlopen error [Errno -2] Name or service not known> seqan2.x86_64: W: only-non-binary-in-usr-lib seqan2.x86_64: E: script-without-shebang /usr/bin/plot.awk seqan2.x86_64: E: script-without-shebang /usr/bin/ps2pswLinks.gawk seqan2.x86_64: W: no-manual-page-for-binary alf [ no-manual-page warnings removed] seqan2-devel.x86_64: W: invalid-license and MIT seqan2-devel.x86_64: W: only-non-binary-in-usr-lib seqan2-debuginfo.x86_64: W: invalid-url URL: http://www.seqan.de/ <urlopen error [Errno -2] Name or service not known> seqan2-debuginfo.x86_64: E: useless-provides debuginfo(build-id) seqan2-examples.x86_64: W: invalid-url URL: http://www.seqan.de/ <urlopen error [Errno -2] Name or service not known> seqan2-examples.x86_64: W: no-documentation seqan2-doc.noarch: W: invalid-url URL: http://www.seqan.de/ <urlopen error [Errno -2] Name or service not known> seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/css/css /usr/share/font-awesome/css seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/fonts/fonts /usr/share/font-awesome/fonts seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/less/less /usr/share/font-awesome/less seqan2-doc.noarch: W: dangling-symlink /usr/share/doc/seqan2/html/lib/font-awesome/scss/scss /usr/share/font-awesome/scss 5 packages and 0 specfiles checked; 3 errors, 62 warnings. Requires -------- seqan2 (rpmlib, GLIBC filtered): /bin/bash gawk(x86-64) ld-linux-x86-64.so.2()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libgomp.so.1(OMP_2.0)(64bit) libgomp.so.1(OMP_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) seqan2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) pkgconfig(zlib) seqan2-debuginfo (rpmlib, GLIBC filtered): seqan2-examples (rpmlib, GLIBC filtered): seqan2(x86-64) seqan2-doc (rpmlib, GLIBC filtered): fontawesome-fonts-web Provides -------- seqan2: bundled(gnulib) seqan seqan2 seqan2(x86-64) seqan2-devel: cmake(seqan) pkgconfig(seqan-2) seqan2-devel seqan2-devel(x86-64) seqan2-debuginfo: debuginfo(build-id) seqan2-debuginfo seqan2-debuginfo(x86-64) seqan2-examples: seqan2-examples seqan2-examples(x86-64) seqan2-doc: bundled(3l) bundled(bootstrap) bundled(less) seqan-doc seqan2-doc Source checksums ---------------- https://github.com/seqan/seqan/archive/8a875d71478a464de5ac3bcf2707f46819285a1f.zip#/seqan-8a875d71478a464de5ac3bcf2707f46819285a1f.zip : CHECKSUM(SHA256) this package : 54bf294953505ca9efa750d1cc27e1ad5dc33a7db20c3f75226c08b646a21d2e CHECKSUM(SHA256) upstream package : 54bf294953505ca9efa750d1cc27e1ad5dc33a7db20c3f75226c08b646a21d2e Generated by fedora-review 0.6.1 (68aeafa) last change: 2017-09-14 Command line :./try-fedora-review -c -b 1531955 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
