https://bugzilla.redhat.com/show_bug.cgi?id=1531955 --- Comment #14 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to Antonio Trande from comment #13) > (In reply to Alec Leamas from comment #12) > > Hi! > > ======= > > - If (and only if) the source package includes the text of the license(s) > > in its own file, then that file, containing the text of the license(s) > > for the package is included in %license. > > Note: License file LICENSE is not marked as %license > > See: > > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > > It is as GPLv3+, BSD and LGPLv3+ Yes, no doubt. But the GL doesn't really seem to care - they just require that these files should be included, full stop. You'll need include all of them. I agree this is a mess, but GL being what they are I see no alternative. Debian has a better system here, and IIRC there has been Fedora discussions on hardlinking these files. But I'm not aware of any conclusion. > > - The devel package has no R: %{name}%{?_isa} = %{version}-%{release} > > (GL reference in comment #9) > > Devel sub-package does not need 'seqan'. They're independant. OK, this is nothing like usual. Are you sure -devel is the proper name? That said, this is C++ and you can do a lot in headers. If you are sure you can do useful things with -devel without the base package, then you're certainly right. That said, it looks weird. > > - The scripts /usr/bin/plot.awk and /usr/bin/ps2pswLinks.gawk are > > executable but has no shebang. Looking at them, it seems that they are > > no scripts, should be 444 and thus live somewhere else (/usr/share?) > > > > Here i don't know how manage these files. Let me check. I would just have made them 444 and moved them to /usr/share/seqan2 in %install, checking references and add a note to README.fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
