https://bugzilla.redhat.com/show_bug.cgi?id=1519607 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Luya. (In reply to Luya Tshimbalanga from comment #1) > Finally found the time for the review. No worries. December got super busy for me, too, as evidenced by the fact that I am only now getting back to Fedora issues... > Additionally, replace %setup -q -n %{user}-NautyTracesInterface-%{shorttag} > by > %autosetup -p1 -n %{user}-NautyTracesInterface-%{shorttag} Done. > Issues: > ======= > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc-c++ > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 I wish somebody would fix that. Rpmlint is wrong about this. Try following that URL. :-) The BR is required: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Apache (v2.0)", "GPL (v2)". > Could you check with upstream about the licensing from the following: > Apache (v2.0) > ------------- > sebasguts-NautyTracesInterface-5f16120/nauty26r7/COPYRIGHT > > GPL (v2) > -------- > sebasguts-NautyTracesInterface-5f16120/COPYING > > Main reason is the compatibility between Apache 2.0 and GPLv2 as highlighted > by > https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses The nauty distribution is packaged separately in Fedora, and this is in %prep: # Make sure the bundled nauty is not used rm -fr src/nauty* Plus, the lone patch in this package removes dependencies on the bundled version of nauty in favor of dependencies on the system version. So none of the Apache-licensed code is in the binary package. > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) Oops. Fixed. In addition, the package identifies itself as version 0.2, not 0.1, when it loads, so I have corrected the version field. New URLs: Spec URL: https://jjames.fedorapeople.org/gap-pkg-nautytracesinterface/gap-pkg-nautytracesinterface.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-nautytracesinterface/gap-pkg-nautytracesinterface-0.2-1.20171120git5f16120.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
