https://bugzilla.redhat.com/show_bug.cgi?id=1519607 --- Comment #1 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- Finally found the time for the review. Additionally, replace %setup -q -n %{user}-NautyTracesInterface-%{shorttag} by %autosetup -p1 -n %{user}-NautyTracesInterface-%{shorttag} Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL (v2)". Could you check with upstream about the licensing from the following: Apache (v2.0) ------------- sebasguts-NautyTracesInterface-5f16120/nauty26r7/COPYRIGHT GPL (v2) -------- sebasguts-NautyTracesInterface-5f16120/COPYING Main reason is the compatibility between Apache 2.0 and GPLv2 as highlighted by https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gap-pkg- nautytracesinterface-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: gap-pkg-nautytracesinterface-0.1-1.20171120git5f16120.fc26.x86_64.rpm gap-pkg-nautytracesinterface-debuginfo-0.1-1.20171120git5f16120.fc26.x86_64.rpm gap-pkg-nautytracesinterface-0.1-1.20171120git5f16120.fc26.src.rpm gap-pkg-nautytracesinterface.x86_64: W: spelling-error Summary(en_US) nauty -> nasty, natty, naughty gap-pkg-nautytracesinterface.x86_64: W: spelling-error %description -l en_US nauty -> nasty, natty, naughty gap-pkg-nautytracesinterface.src: W: spelling-error Summary(en_US) nauty -> nasty, natty, naughty gap-pkg-nautytracesinterface.src: W: spelling-error %description -l en_US nauty -> nasty, natty, naughty 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: gap-pkg-nautytracesinterface-debuginfo-0.1-1.20171120git5f16120.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory gap-pkg-nautytracesinterface-debuginfo.x86_64: W: invalid-url URL: https://github.com/sebasguts/NautyTracesInterface <urlopen error [Errno -2] Name or service not known> gap-pkg-nautytracesinterface.x86_64: W: spelling-error Summary(en_US) nauty -> nasty, natty, naughty gap-pkg-nautytracesinterface.x86_64: W: spelling-error %description -l en_US nauty -> nasty, natty, naughty gap-pkg-nautytracesinterface.x86_64: W: invalid-url URL: https://github.com/sebasguts/NautyTracesInterface <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/luya/Documents/fedora-packaging/review/1519607-gap-pkg-nautytracesinterface/srpm/gap-pkg-nautytracesinterface.spec 2017-12-01 22:17:51.780362297 -0800 +++ /home/luya/Documents/fedora-packaging/review/1519607-gap-pkg-nautytracesinterface/srpm-unpacked/gap-pkg-nautytracesinterface.spec 2017-11-28 20:20:59.000000000 -0800 @@ -26,6 +26,5 @@ %description -The Digraphs package is a GAP package containing methods for graphs, -digraphs, and multidigraphs. +This GAP package provides an interface to nauty and Traces. %prep Requires -------- gap-pkg-nautytracesinterface-debuginfo (rpmlib, GLIBC filtered): gap-pkg-nautytracesinterface (rpmlib, GLIBC filtered): gap-core ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libnauty.so.2()(64bit) libnauty.so.2(LIBNAUTY_2.5)(64bit) rtld(GNU_HASH) Provides -------- gap-pkg-nautytracesinterface-debuginfo: gap-pkg-nautytracesinterface-debuginfo gap-pkg-nautytracesinterface-debuginfo(x86-64) gap-pkg-nautytracesinterface: gap-pkg-nautytracesinterface gap-pkg-nautytracesinterface(x86-64) libNautyTracesInterface.so.0()(64bit) Unversioned so-files -------------------- gap-pkg-nautytracesinterface: /usr/lib/gap/pkg/nautytracesinterface/bin/x86_64-redhat-linux-gnu-gcc-default64/NautyTracesInterface.so Source checksums ---------------- https://github.com/sebasguts/NautyTracesInterface/tarball/5f1612076923ec624657a51e520bef1a52cf3ed1/sebasguts-nautytracesinterface-5f16120.tar.gz : CHECKSUM(SHA256) this package : bbb4b639c8d051b949720f854bc15e992a76445bbb7d9609f5fe2e6a5d7867e5 CHECKSUM(SHA256) upstream package : bbb4b639c8d051b949720f854bc15e992a76445bbb7d9609f5fe2e6a5d7867e5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
