https://bugzilla.redhat.com/show_bug.cgi?id=1433657 --- Comment #5 from Michal Ambroz <rebus@xxxxxxxxx> --- Spec URL: http://rebus.fedorapeople.org/SPECS/vncpwd.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/vncpwd-0.0-3.20170607git596854c.fc27.src.rpm >- Please update to latest git revision: 596854c237e26b3f615d933e8abd040f1ed9b5c9 updated >- Please include a commit date for versioning: added >- use %make_build instead of just make used > - Group: is not used in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections removed > - The package doesn't generate debugging symbols, you should add: > %global debug_package %{nil} I have rather patched to honor the optflags > - You should patch the FSF address in the README and notify upstream. Reported upstream, but not patched -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx