https://bugzilla.redhat.com/show_bug.cgi?id=1519607 Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- Focusing on the fixed errors: (In reply to Jerry James from comment #2) > Thank you for the review, Luya. > > > Additionally, replace %setup -q -n %{user}-NautyTracesInterface-%{shorttag} > > by > > %autosetup -p1 -n %{user}-NautyTracesInterface-%{shorttag} > > Done. > > > Issues: > > ======= > > - All build dependencies are listed in BuildRequires, except for any that > > are listed in the exceptions section of Packaging Guidelines. > > Note: These BR are not needed: gcc-c++ > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > > I wish somebody would fix that. Rpmlint is wrong about this. Try following > that URL. :-) The BR is required: > https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B I confirm rpmlint has outdated info related to gcc-c++. Skipping that part. > The nauty distribution is packaged separately in Fedora, and this is in > %prep: > > # Make sure the bundled nauty is not used > rm -fr src/nauty* > > Plus, the lone patch in this package removes dependencies on the bundled > version of nauty in favor of dependencies on the system version. So none of > the Apache-licensed code is in the binary package. Thanks for the explanation. Then the GPLv2+ license is correct in this case. Following these correction, the package is APPROVED. Happy new year! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
