https://bugzilla.redhat.com/show_bug.cgi?id=1509034 --- Comment #4 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Ok, a couple of questions: 1. There is one directory left in the "thirdparty" directory. Is it required and not bundled? 2. The build generates a LOT of warnings, it was difficult to find a compile line to verify the build flags were being honored. The project seems to be using C++11 but in Fedora 26 and up, C++14 is standard. Unless the project will not build with C++14, the flag should be removed. 3. rpmlint doesn't like the ICU license.. It looks like an MIT variant, correct? 4. These are only warnings but they should be fixed: phd2.x86_64: W: spurious-executable-perm /usr/share/doc/phd2/PHD_2.0_Architecture.docx In %install: chmod 0644 %{buildroot}%{_docdir}/%{name}/PHD_2.0_Architecture.docx phd2.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/phd2/README-PHD2.txt There are several options for fixing line endings... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
