https://bugzilla.redhat.com/show_bug.cgi?id=1509034 --- Comment #5 from Mattia Verga <mattia.verga@xxxxxxxx> --- (In reply to Richard Shaw from comment #4) > Ok, a couple of questions: > > 1. There is one directory left in the "thirdparty" directory. Is it required > and not bundled? Removed. > 2. The build generates a LOT of warnings, it was difficult to find a compile > line to verify the build flags were being honored. > > The project seems to be using C++11 but in Fedora 26 and up, C++14 is > standard. Unless the project will not build with C++14, the flag should be > removed. Added a patch to use C++14. I might ask upstream if the patch is feasible to be included upstream. > 3. rpmlint doesn't like the ICU license.. It looks like an MIT variant, > correct? Yes, changed to MIT: https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Modern_style_.28ICU_Variant.29 > 4. These are only warnings but they should be fixed: > > phd2.x86_64: W: spurious-executable-perm > /usr/share/doc/phd2/PHD_2.0_Architecture.docx > > In %install: > chmod 0644 %{buildroot}%{_docdir}/%{name}/PHD_2.0_Architecture.docx > > phd2.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/phd2/README-PHD2.txt > > There are several options for fixing line endings... Fixed. Spec URL: https://mattia.fedorapeople.org/phd2.spec SRPM URL: https://mattia.fedorapeople.org/phd2-2.6.4-3.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
