[Bug 1509034] Review Request: phd2 - Telescope guiding software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1509034

Richard Shaw <hobbes1069@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #3 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
Quick spec review first:


Could change:

In %prep:
%setup 

to

%autosetup -p1

---

In %build:
make %{?_smp_mflags} -C %{_target_platform}

to

%make_build

There's no reason to popd out of the directory, you can run make there and then
you don't need the -C...

---

In %install
make install -C %{_target_platform} DESTDIR=%{buildroot}

to

pushd %{_target_platform}
%make_install
popd (for find_lang)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux