Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkperf - Test GTK+ performance https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248778 ------- Additional Comments From patrice.bouchand.fedora@xxxxxxxxx 2007-08-10 07:23 EST ------- > * Fedora specific compilation flags are not honored > (Compiler flags of http://fedoraproject.org/wiki/Packaging/Guidelines ) > Check the log: > http://koji.fedoraproject.org/koji/getfile?taskID=92083&name=build.log > Also debuginfo rpm does not contain debug information and this > should be fixed. CFLAGS entry in Makefile is empty. I did not find yet why configure substitutes @CFLAGS@ with an empty string in Makefile.in. I try this which seems to work: |for f in `find -name Makefile` | do | sed -i -e "s/^CFLAGS =.*$/CFLAGS = %{optflags}/" $f | done but I do not think it's acceptable. Do you have an idea about what could be wrong ? > * (From build log) > Suppress the call of automated autoheader ("touch"ing some files, > i.e. fixing the timestamp of some files should fix this issue) Done > * Update License tag. (IMO this is GPLv2, not GPLv2+) Done > * Change the encoding of "ChangeLog" from ISO-8859-1 to UTF-8. Done -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review