[Bug 248778] Review Request: gtkperf - Test GTK+ performance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkperf - Test GTK+ performance


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248778





------- Additional Comments From rc040203@xxxxxxxxxx  2007-08-10 09:45 EST -------
(In reply to comment #12)
> CFLAGS entry in Makefile is empty. I did not find yet why configure substitutes
> @CFLAGS@ with an empty string in Makefile.in. 
The culprit is a bug in configure.in
...
CFLAGS=""
AC_SUBST(CFLAGS)
...

Here they overwrite CFLAGS with an empty string, which causes the configure
script to propagate this empty string into the Makefiles.

The "right fix" would be upstream to remove these two lines. They are plain wrong.

A work-around applicable to packagers is to override CFLAGS from the
environment. I.e. use
make CFLAGS=${RPM_OPT_FLAGS}
in all places in your spec where you invoke "make".


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]