Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkperf - Test GTK+ performance https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248778 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-08-08 12:11 EST ------- Some remarks. * Fedora specific compilation flags are not honored (Compiler flags of http://fedoraproject.org/wiki/Packaging/Guidelines ) Check the log: http://koji.fedoraproject.org/koji/getfile?taskID=92083&name=build.log Also debuginfo rpm does not contain debug information and this should be fixed. * (From build log) Suppress the call of automated autoheader ("touch"ing some files, i.e. fixing the timestamp of some files should fix this issue) * Update License tag. (IMO this is GPLv2, not GPLv2+) * Change the encoding of "ChangeLog" from ISO-8859-1 to UTF-8. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review