https://bugzilla.redhat.com/show_bug.cgi?id=1474948 --- Comment #3 from Debarshi Ray <debarshir@xxxxxxxxxx> --- (In reply to Kalev Lember from comment #2) Thanks for the review! > Just two minor things I'd change: > > 1) add '%dir %{_libdir}/girepository-1.0' to %files so that the directory > gets properly removed when the package is uninstalled > 2) compat-tracker018 and compat-tracker016 obsoletes semantically belong to > tracker and not here, I think. Removing these would also conveniently fix > the rpmlint warning above. Makes sense. I have changed those. Spec: https://rishi.fedorapeople.org/compat-tracker1.spec SRPM: https://rishi.fedorapeople.org/compat-tracker1-1.12.1-2.fc25.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20764897 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
