https://bugzilla.redhat.com/show_bug.cgi?id=1474948 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |klember@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |klember@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Kalev Lember <klember@xxxxxxxxxx> --- Fedora review compat-tracker1-1.12.1-1.fc25.src.rpm 2017-07-26 $ rpmlint compat-tracker1-1.12.1-1.fc25.src.rpm \ compat-tracker1-1.12.1-1.fc26.x86_64.rpm \ compat-tracker1-debuginfo-1.12.1-1.fc26.x86_64.rpm compat-tracker1.x86_64: W: obsolete-not-provided compat-tracker016 compat-tracker1.x86_64: W: obsolete-not-provided compat-tracker018 3 packages and 0 specfiles checked; 0 errors, 2 warnings. + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The license text (COPYING) is included in %license + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm a99bc07515d74e2a3b578ddba061060566aad00d8d9579fb726105db66da5374b40222dc23e7323b244a595c856ddb3b6c7ccc6be1a13cbb8669f93d0afd8b59 tracker-1.12.1.tar.xz a99bc07515d74e2a3b578ddba061060566aad00d8d9579fb726105db66da5374b40222dc23e7323b244a595c856ddb3b6c7ccc6be1a13cbb8669f93d0afd8b59 Download/tracker-1.12.1.tar.xz + The package builds in koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=20725596) n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling + ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable ! Package owns all the directories it creates %{_libdir}/girepository-1.0 directory is missing from %files (it's also a problem in the tracker where this was copied from). + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Just two minor things I'd change: 1) add '%dir %{_libdir}/girepository-1.0' to %files so that the directory gets properly removed when the package is uninstalled 2) compat-tracker018 and compat-tracker016 obsoletes semantically belong to tracker and not here, I think. Removing these would also conveniently fix the rpmlint warning above. Beyond that, looks nice and clean. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
