https://bugzilla.redhat.com/show_bug.cgi?id=1474694 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, A few notes regarding your SPEC: - SOURCE0 should point to the URL of the archive. For example in your case, SOURCE0: https://github.com/PJK/libcbor/archive/v%{version}.tar.gz#/${name}-%{version}.tar.gz - you can use rpm macros for cp and mkdir -p: - cp → %{__cp} - mkdir -p → %{__mkdir_p} - %setup -q is fine but note that you can also use %autosetup . It patches the source automatically if you ever need patch. - I would put the %cmake macro in %build, not %prep - These BR are not needed: gcc gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - I would repeat you short description in the -devel package too: "libcbor is a C library for parsing and generating CBOR. The %{name}-devel contains libraries and header files for %{name}." - The "Group:" tag should not be used. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections Thank you -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
