[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1468665



--- Comment #3 from Zamir SUN <sztsian@xxxxxxxxx> ---
Thanks for the review

SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt.spec
Updated
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt-0-0.r83.fc25.src.rpm

> [!]: Package requires other packages for directories it uses.
>     Note: No known owner of /usr/include/qt5/QGSettings
> [!]: Package must own all directories that it creates.
>     Note: Directories without known owners: /usr/include/qt5/QGSettings,
>     /usr/include/qt5
I did not see this when I run fedora-review on my machine. I tried to fix it
but not sure if it is fixed on your end or not.
> [!]: Requires correct, justified where necessary.
I have justification in the SPEC file as comment. Not sure why this fails.
> [!]: Uses parallel make %{?_smp_mflags} macro.
Commented in the SPEC already. This will always fail in parallel make. So I
write a comment in SPEC and use make 

> [!]: Package should compile and build into binary rpms on all supported
>     architectures.
Failed on big endian machines. Excluded the two arch in spec now.
> [!]: Rpmlint is run on all installed packages.
>     Note: Mock build failed
>     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
Again, unfortunately mock build passed on my machine. And RPM lint do not
complain any hidden file. Not sure why this happens, or how can I reproduce
this.

Others should already fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux