https://bugzilla.redhat.com/show_bug.cgi?id=1468665 --- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/qt5/QGSettings [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/qt5/QGSettings, /usr/include/qt5 The devel subpackage should require qt5-qtbase-devel%{?isa} [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. Note: Changelog entries should be separated by an empty line. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines Note: Version is bad, follow https://fedoraproject.org/wiki/Packaging:Versioning#Upstream_has_never_chosen_a_version Note: Source0 URL can be revised using the '#/' notation to something like this: http://bazaar.launchpad.net/%{project}/%{name}/trunk/tarball/%{_revision}#/%{name}-%{_revision}.tar.gz Refer to: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). Note: libGSettingsQmlPlugin.so()(64bit) provides should be filtered. https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_deps_.28pre-scan_filtering.29 [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gsettings-qt-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. Note: Build failed on ppc64 and s390x https://koji.fedoraproject.org/koji/taskinfo?taskID=20463360 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [!]: "-n %{name}" in %post and %postun is not required. [!]: Defining %_qt5_qmldir is not required since F24 will be obsolete soon. [!]: %{_qt5_qmldir}/GSettings.1.0/ should go to the base package. [!]: Summary and description should be saying "Qt/QML", not just "QML" Rpmlint ------- Checking: gsettings-qt-0.1.r83-1.fc27.x86_64.rpm gsettings-qt-devel-0.1.r83-1.fc27.x86_64.rpm gsettings-qt-debuginfo-0.1.r83-1.fc27.x86_64.rpm gsettings-qt-0.1.r83-1.fc27.src.rpm gsettings-qt.x86_64: W: no-documentation gsettings-qt.x86_64: W: hidden-file-or-dir /usr/lib/.build-id gsettings-qt.x86_64: W: hidden-file-or-dir /usr/lib/.build-id gsettings-qt-devel.x86_64: W: no-documentation gsettings-qt-devel.x86_64: W: hidden-file-or-dir /usr/lib/.build-id gsettings-qt-devel.x86_64: W: hidden-file-or-dir /usr/lib/.build-id gsettings-qt.src: W: invalid-url Source0: gsettings-qt-r83.tgz 4 packages and 0 specfiles checked; 0 errors, 7 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/cheese/1468665-gsettings-qt/srpm/gsettings-qt.spec 2017-07-09 22:02:06.905040250 +0800 +++ /home/cheese/1468665-gsettings-qt/srpm-unpacked/gsettings-qt.spec 2017-07-07 23:50:46.000000000 +0800 @@ -21,5 +21,5 @@ BuildRequires: qt5-qtdeclarative-devel BuildRequires: glib2-devel -BuildRequires: gcc-c++ +BuildRequires: libstdc++-devel %description Requires -------- gsettings-qt-debuginfo (rpmlib, GLIBC filtered): gsettings-qt (rpmlib, GLIBC filtered): /sbin/ldconfig libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.9)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) gsettings-qt-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gsettings-qt(x86-64) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.9)(64bit) libQt5Core.so.5(Qt_5_PRIVATE_API)(64bit) libQt5Network.so.5()(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgsettings-qt.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) Provides -------- gsettings-qt-debuginfo: gsettings-qt-debuginfo gsettings-qt-debuginfo(x86-64) gsettings-qt: gsettings-qt gsettings-qt(x86-64) libgsettings-qt.so.1()(64bit) gsettings-qt-devel: gsettings-qt-devel gsettings-qt-devel(x86-64) libGSettingsQmlPlugin.so()(64bit) pkgconfig(gsettings-qt) Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1468665 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
