[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1468665



--- Comment #4 from Robin Lee <robinlee.sysu@xxxxxxxxx> ---
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/include/qt5
     The devel subpackage should require qt5-qtbase-devel%{?isa}

[!]: The commented line of SOURCE0 should be removed

[!]: The comment of downloading source should be removed.

[!]: Macros in comment:
     # %global _qt5_qmldir %{_qt5_archdatadir}/qml

[!]: %{_qt5_qmldir}/GSettings.1.0/ should go to the base package.
     That means for the whole directory tree of %{_qt5_qmldir}/GSettings.1.0/

[!]: The Release: tag is still bad, follow:
     https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
    
https://fedoraproject.org/wiki/Packaging:Versioning#More_complex_versioning
     It should be something like: 0.0.20170714bzr83%{?dist}

[!]: 'QT' should be 'Qt'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux