https://bugzilla.redhat.com/show_bug.cgi?id=1463492 --- Comment #11 from s1061123@xxxxxxxxx --- (In reply to srakitnican from comment #10) > No sure about (In reply to s1061123 from comment #9) > > Hi srakitnican, > > > > Thank you for your review again! > > > > Here is the modified spec/SRPM, all comments above are taken care of it. > > BTW, I need to keep 'git' in its 'BuildRequires:' because 'go get' invokes > > git command internally, hence build is failed without git command. > > I guess the question is now why you are doing "go get", don't you have the > sources already available from a tarball? Either way, I don't know much > about go, will leave this issue for someone else. sure. let's wait other opinion. > Small note, with your new spec file rpmlint complains about macro in the > changelog. You can disable a macro with %, for example %%post . I've taken care of it and upload it. Spec URL: http://s1061123.net/koko/koko_v04.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/s1061123/koko/fedora-rawhide-x86_64/00577438-koko/koko-0.4-1.src.rpm copr build URL: https://copr.fedorainfracloud.org/coprs/s1061123/koko/build/577438/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
