[Bug 1463492] Review Request: koko - container connector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1463492



--- Comment #10 from srakitnican <samuel.rakitnican@xxxxxxxxx> ---
No sure about (In reply to s1061123 from comment #9)
> Hi srakitnican,
> 
> Thank you for your review again!
> 
> Here is the modified spec/SRPM, all comments above are taken care of it.
> BTW, I need to keep 'git' in its 'BuildRequires:' because 'go get' invokes
> git command internally, hence build is failed without git command.

I guess the question is now why you are doing "go get", don't you have the
sources already available from a tarball? Either way, I don't know much about
go, will leave this issue for someone else.


Small note, with your new spec file rpmlint complains about macro in the
changelog. You can disable a macro with %, for example %%post .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux