https://bugzilla.redhat.com/show_bug.cgi?id=1452649 --- Comment #7 from Luke Hinds <lhinds@xxxxxxxxxx> --- Hi Rich, Fixed up quite a lot now. Some notes: - %defattr is not needed. It can be deleted. done - Group is not needed. It can be deleted. done - The %{!?...} lines at the top are not needed in Fedora (not sure about RHEL). I did try removing these, but they appear to be needed for %{__python2}, %{python2_sitelib} directives to work. Some details here: https://fedoraproject.org/wiki/Packaging:Python_Old (see Macros) This package will be cherry picked(?) into CentOS / RHEL for RDO use, so needs those. - exabgp.noarch: E: description-line-too-long done - exabgp.noarch: E: non-standard-executable-perm done - exabgp.noarch: W: spurious-executable-perm /usr/share/man/man1/exabgp.1.gz - exabgp.noarch: W: manual-page-warning /usr/share/man/man1/exabgp.1.gz 3: warning: macro `OS' not defined - exabgp.noarch: W: spurious-executable-perm /usr/share/man/man5/exabgp.conf.5.gz - exabgp.noarch: W: manual-page-warning /usr/share/man/man5/exabgp.conf.5.gz 3: warning: macro `OS' not defined Not sure what to do about these, I did google around and could only find an old comment from yours truly: https://bugzilla.redhat.com/show_bug.cgi?id=467397#c4 p.s. latest files are commited to the original links, so a fedora-review -b will pull in the latest changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
