[Bug 1452649] Review Request: python-exabgp - Package review request for ExaBGP spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1452649



--- Comment #8 from Richard W.M. Jones <rjones@xxxxxxxxxx> ---
%doc COPYRIGHT

should be

%license COPYRIGHT

The other two %doc files are OK as they are not license files.
Unfortunately I don't think that %license will work on RHEL
so you may need some %if's around that.

The package couldn't be installed (in a chroot).  However fedora-review
doesn't keep the actual error from that, so it might just be an error
caused by the systemd unit scripts.

The exabgp package depends on /usr/bin/perl which seems to be a bug.
Although the documentation mentions "a perl based healthcheck program",
the one included in this package is most definitely written in Python,
and there are no other perl binaries or libraries that I can see.

There are still loads of rpmlint errors of this kind:

  exabgp.noarch: E: non-executable-script
/etc/exabgp/examples/api-announcement.run 644 /usr/bin/env python

rpmlint is literally correct here that there is a script which is not
executable.  Is it intended that the end user will chmod +x the script(s)
that they need?

Another rpmlint problem is:

  exabgp.noarch: W: non-conffile-in-etc /etc/exabgp/examples/api-api.conf       

If these files are meant to be edited, then they must be marked as %config
or %config(noreplace) in the spec:

  https://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files

If they are not meant to be edited (just symlinked to) then
I guess moving them to /usr/lib/exabgp is a better idea?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux