https://bugzilla.redhat.com/show_bug.cgi?id=1452649 --- Comment #6 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- Fedora-review is complaining that the spec file and the spec file inside the SRPM (both linked from comment 4) are slightly different, but it's only the %description which is different, so don't worry about it for now. A few issues about the spec file in general. - %defattr is not needed. It can be deleted. - Group is not needed. It can be deleted. - The %{!?...} lines at the top are not needed in Fedora (not sure about RHEL). I'm still seeing a large number of rpmlint errors, so let's see: python-exabgp.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/exabgp/application/bmp.py /usr/bin/env python python-exabgp.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/exabgp/application/bmp.py 644 /usr/bin/env python - This (and similar) is likely to be wrong, unless (a) that file is really a script rather than a library and (b) it can run under any version of python2 (or any version of python if we later rename python3 -> python). However the Python Packaging Guidelines seem to be silent on this so I don't know if it's a packaging bug. exabgp.noarch: E: description-line-too-long C ExaBGP allows engineers to control their network from commodity servers. Think of it as Software Defined Networking using BGP by transforming BGP messages into friendly plain text or JSON. - Worth folding the lines at 72 chars I guess. exabgp.noarch: E: non-standard-executable-perm /etc/exabgp/examples/addpath.conf 744 exabgp.noarch: E: script-without-shebang /etc/exabgp/examples/addpath.conf - That doesn't make much sense for any file. Should it be 0644? In the spec file: %attr(744, root, root) %{_sysconfdir}/exabgp/examples/* exabgp.noarch: W: spurious-executable-perm /usr/share/man/man1/exabgp.1.gz exabgp.noarch: W: manual-page-warning /usr/share/man/man1/exabgp.1.gz 3: warning: macro `OS' not defined exabgp.noarch: W: spurious-executable-perm /usr/share/man/man5/exabgp.conf.5.gz exabgp.noarch: W: manual-page-warning /usr/share/man/man5/exabgp.conf.5.gz 3: warning: macro `OS' not defined - Should be fixable I think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
