https://bugzilla.redhat.com/show_bug.cgi?id=1447741 --- Comment #6 from Charles R. Anderson <cra@xxxxxxx> --- Spec URL: https://cra.fedorapeople.org/sedutil/sedutil.spec SRPM URL: https://cra.fedorapeople.org/sedutil/sedutil-1.12-3.fc27.src.rpm All issues should be addressed as I stated in comment #5. > > BSD > I'm working on the licensing fixes and have also filed this upstream: > https://github.com/Drive-Trust-Alliance/sedutil/issues/145 License: tag fixed. > > GPL (v2 or later) > > sedutil-1.12/Common/pbkdf2/gc-gnulib.c > > This is a copy of some files from gnulib. I'll see if I can compile against > a system-wide copy, otherwise put a bundled(gnulib) provide in. Added Provides: bundled(gnulib). > > help2man --no-discard-stderr .../sedutil-cli I provided a manual page by starting with help2man and editing the result. > > Is linuxpba really supposed to be installed under > > /usr/bin ? Since it asks a password, maybe it needs > > CAP_SYS_BOOT capability. I moved it to /usr/libexec/linuxpba. > > The macros in spec comments should be changed or > > escaped. Fixed by removing the commented out unused macros for now. > > Most of the spec uses tabs, but ExclusiveArch and > > Obsolete tag lines use spaces. Just a cosmetic fix. Fixed, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
