https://bugzilla.redhat.com/show_bug.cgi?id=1447741 --- Comment #5 from Charles R. Anderson <cra@xxxxxxx> --- (In reply to Paulo Andrade from comment #4) > There are some mixed licenses: > > BSD > --- > sedutil-1.12/Common/DtaAnnotatedDump.cpp > sedutil-1.12/Common/DtaAnnotatedDump.h > sedutil-1.12/Common/DtaHexDump.h I'm working on the licensing fixes and have also filed this upstream: https://github.com/Drive-Trust-Alliance/sedutil/issues/145 > GPL (v2 or later) > ----------------- > sedutil-1.12/Common/pbkdf2/gc-gnulib.c > sedutil-1.12/Common/pbkdf2/gc-pbkdf2-sha1.c > sedutil-1.12/Common/pbkdf2/gc.h > sedutil-1.12/Common/pbkdf2/hmac-sha1.c > sedutil-1.12/Common/pbkdf2/hmac.h > sedutil-1.12/Common/pbkdf2/memxor.c > sedutil-1.12/Common/pbkdf2/memxor.h > sedutil-1.12/Common/pbkdf2/sha1.c > sedutil-1.12/Common/pbkdf2/sha1.h > sedutil-1.12/Common/pbkdf2/stdalign.h This is a copy of some files from gnulib. I'll see if I can compile against a system-wide copy, otherwise put a bundled(gnulib) provide in. > ----- > Documentation about the binaries and/or options would be > good. linux-pba does not accept options, and sedutil-cli > almost provides a man page with: > > help2man --no-discard-stderr .../sedutil-cli I'll try help2man. > Is linuxpba really supposed to be installed under > /usr/bin ? Since it asks a password, maybe it needs > CAP_SYS_BOOT capability. Perhaps not, it isn't really intended to be run by a regular user at all. It is intended to be embedded into a Pre-Boot Authorization image to be run automatically upon boot before the unencrypted disk is available. It could theoretically be used in the normal boot sequence to decrypt non-boot disks too. Would you agree to this being moved to /usr/libexec/linuxpba? > ----- > > The macros in spec comments should be changed or > escaped. > > Most of the spec uses tabs, but ExclusiveArch and > Obsolete tag lines use spaces. Just a cosmetic fix. Fixed, thanks. I'll provide a new spec/srpm after working out issues above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
