https://bugzilla.redhat.com/show_bug.cgi?id=1448451 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Thanks. Release: Naming: ok License: ok Sources: ok (generating script included). macros: ok 1. SHOULD use %{_qt5_docdir} instead of %{_docdir} macro, ie, replace %{_docdir}/qt5/ references with just: %{_qt5_docdir} 2. subpackage deps SHOULD use full version-release, like: Requires: qt5-qtbase-doc = %{version}-%{release} scriplets: n/a 3. SHOULD use proper Release tag, something like Release: 0.3.beta3%{?dist} instead of existing Release: 0.beta.3%{?dist} style I won't consider these blockers, and can easily be fixed after import. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
