https://bugzilla.redhat.com/show_bug.cgi?id=1427085 Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dwrobel@ertelnet. | |rybnik.pl) | --- Comment #7 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- (In reply to Raphael Groner from comment #4) > Sorry for the very long delay here. I had a lot of daily job work to do. It's absolutely no problem as the same applies to others as well - I'm sorry for the delay. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > > MUST fix: > - update-desktop-database is invoked in %post and %postun if package removed > - Can not completely validate GPLv3+ of source files due to missing headers, > please poke upstream about those: upstream updated source files > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Multiple_Licensing_Scenarios without bundled qtsingleapplication library it becomes single licensed package > - Remove duplication of folders ownership, see note below. removed, except %{_datadir}/icons/hicolor/scalable/apps for which I applied: https://fedoraproject.org/wiki/Packaging:Guidelines#The_package_you_depend_on_to_provide_a_directory_may_choose_to_own_a_different_directory_in_a_later_version_and_your_package_will_run_unmodified_with_that_later_version > - Note correct release string in changelog, see rpmling warning. It's according to https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots. > - Unbundle qtsingleapplication, it's available as a separate package. unbundled > > SHOULD fix: > - May want to use latest commit for the package. As of now: 7a96d90 packaged the latest one (includes updated license header) > - Please include README.mime into %doc, it contains useful information > about mime integration. Even better would be if package can configure that. it was already configured in the previous version, thus README.mime migh confuse user > - Please move appstream-util validate-relax from %install into %check. as per https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage it could be: "(in %check or %install)". > - May be worth to run tests of dedicated subfolder in %check. I didn't touch it. > - Please use 'cp -p' to preserve timestamps also for icons and translations. I'm using 'cp -a' which is the "same as -dR --preserve=all". > - Please drop useless /usr/lib/.build-id file, see rpmlint warnings. Strange, as the package never provided anything in the /usr/lib. Please find updated spec and SRPM files: Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/plantumlqeditor.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/plantumlqeditor-1.2-8.20170403git964d4ef.fc25.src.rpm (In reply to Raphael Groner from comment #5) > Scratch build in rawhide fails currently, see bug #1427085. Koji scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=19490015 at the time of writing all builds finished successfully except s390x which seems to got stuck in: "Loading logs for task 19490021....". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
