https://bugzilla.redhat.com/show_bug.cgi?id=1403417 --- Comment #26 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "FSF Unlimited GPL", "*No copyright* FSF All Permissive", "FSF All Permissive", "FSF Unlimited". 147 files have unknown license. Detailed output of licensecheck in /home/mukundan/nextcloud/misc_pkgs/pkg_reviews/1403417-gsequencer/licensecheck.txt ---> Looking at the licensecheck output, this does not seem to be a problem. [?]: License file installed when any subpackage combination is installed. ---> License file is installed as part of the gsequencer package. -devel package has versioned requires for the base packages. However, -devel-doc does not depend on -devel or the base package. As far as I can tell, -devel-doc should also have versioned requires. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gtk-doc(gegl- devel, libsecret-devel, clipsmm-doc, redland-devel, libunity-gtk- parser-devel, gnome-desktop3-devel, rasqal-devel, latexila-doc, webkitgtk4-doc, libgtop2-devel, iio-sensor-proxy-docs, libgdl-devel, gocl-devel, vte3-devel, vips-devel, libgpod-doc, eog-devel, libgit2 -glib-devel, libgnome-devel, libxfce4util-devel, p11-kit-devel, gtkimageview-devel, gstreamer1-vaapi-devel-docs, garcon-devel, uprof- devel, libxfce4ui-devel, clutter-gst3-devel, flatpak-devel, vte291-devel, gstreamer1-rtsp-server-devel-docs, tubo-doc, nautilus- devel, libxklavier-devel, gedit-devel, poppler-devel, libzapojit- devel, libwnck-devel, libgweather-devel, yelp-devel, keybinder-devel, gimp-devel, gtk-doc, parole-devel, gnome-todo-devel, tumbler-devel, libpeas-devel, libfm-devel-docs, gfbgraph-devel, xed-doc, polkit-docs, gcr-devel, anjuta-devel, libldm-devel, gtk3-devel-docs, gom-devel, libdbusmenu-doc, dbus-doc, libgnome-keyring-devel, ibus-devel-docs, upower-devel-docs, maliit-framework-docs, harfbuzz-devel, webkitgtk- doc, intel-gpu-tools, raptor2-devel, gtk2-devel-docs, libwnck3-devel, libcanberra-devel, cheese-libs-devel, gspell-doc, glade-devel, gsound- devel, gstreamer-plugins-base-devel-docs, seed-doc, libgdata-devel, gtkspell3-devel, webkitgtk3-doc, libu2f-host-devel, exo-devel, unique- devel, json-glib-devel, gnome-desktop-devel, lasem-devel, gnome- bluetooth-libs-devel, nntpgrab-devel, libidn2-devel, unique3-docs, cutter-devel, tomoe-devel, fprintd-devel, udisks-devel, xfconf-devel, geocode-glib-devel, bamf-devel, gnome-autoar-devel, ORBit2-devel, libgda-devel, anaconda-widgets-devel), /usr/share/gtk-doc/html(gegl- devel, libsecret-devel, clipsmm-doc, redland-devel, libunity-gtk- parser-devel, gnome-desktop3-devel, rasqal-devel, latexila-doc, webkitgtk4-doc, libgtop2-devel, iio-sensor-proxy-docs, libgdl-devel, gocl-devel, vte3-devel, vips-devel, libgpod-doc, eog-devel, libgit2 -glib-devel, libgnome-devel, libxfce4util-devel, p11-kit-devel, gtkimageview-devel, gstreamer1-vaapi-devel-docs, garcon-devel, uprof- devel, libxfce4ui-devel, clutter-gst3-devel, flatpak-devel, vte291-devel, gstreamer1-rtsp-server-devel-docs, tubo-doc, nautilus- devel, libxklavier-devel, gedit-devel, poppler-devel, libzapojit- devel, libwnck-devel, libgweather-devel, yelp-devel, keybinder-devel, gimp-devel, gtk-doc, parole-devel, gnome-todo-devel, tumbler-devel, libpeas-devel, libfm-devel-docs, gfbgraph-devel, xed-doc, polkit-docs, gcr-devel, anjuta-devel, libldm-devel, gtk3-devel-docs, gom-devel, libdbusmenu-doc, dbus-doc, libgnome-keyring-devel, ibus-devel-docs, upower-devel-docs, maliit-framework-docs, harfbuzz-devel, webkitgtk- doc, intel-gpu-tools, raptor2-devel, gtk2-devel-docs, libwnck3-devel, libcanberra-devel, cheese-libs-devel, gspell-doc, glade-devel, gsound- devel, gstreamer-plugins-base-devel-docs, seed-doc, libgdata-devel, gtkspell3-devel, webkitgtk3-doc, libu2f-host-devel, exo-devel, unique- devel, json-glib-devel, gnome-desktop-devel, lasem-devel, gnome- bluetooth-libs-devel, nntpgrab-devel, libidn2-devel, unique3-docs, cutter-devel, tomoe-devel, fprintd-devel, udisks-devel, xfconf-devel, geocode-glib-devel, bamf-devel, gnome-autoar-devel, ORBit2-devel, libgda-devel, anaconda-widgets-devel) ---> This is already discussed and is fine. [x]: %build honors applicable compiler flags or justifies otherwise. ---> Appropriate macros are used and the build log shows proper compiler flags being used. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [?]: Development files must be in a -devel package ---> There seems to at least [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 665600 bytes in 44 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). ---> I did not notice oddities. Please consider the -devel-doc comment above. [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gsequencer-debuginfo , gsequencer-devel-doc ---> -devel-doc again [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. ---> As I mentioned in a previous comment, please add a comment about the patch. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> looks good. https://koji.fedoraproject.org/koji/taskinfo?taskID=18173117 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 10199040 bytes in /usr/share See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines ---> you may want to consider if it's appropriate to move the html docs to -doc subpackage. I do not really have a preference. [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gsequencer-0.7.122.6-1.fc26.x86_64.rpm gsequencer-debuginfo-0.7.122.6-1.fc26.x86_64.rpm gsequencer-devel-0.7.122.6-1.fc26.x86_64.rpm gsequencer-devel-doc-0.7.122.6-1.fc26.x86_64.rpm gsequencer-0.7.122.6-1.fc26.src.rpm gsequencer.x86_64: W: shared-lib-calls-exit /usr/lib64/libags.so.0.0.7 exit@GLIBC_2.2.5 gsequencer.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsequencer/libgsequencer.so ---> This seems to be a symlink to a versioned library. gsequencer-devel.x86_64: W: only-non-binary-in-usr-lib gsequencer-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: gsequencer-debuginfo-0.7.122.6-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- gsequencer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libags.so.0.0.7 ags_mutex_manager_get_instance gsequencer.x86_64: W: undefined-non-weak-symbol /usr/lib64/libags.so.0.0.7 ags_mutex_manager_get_application_mutex gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/librt.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libm.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: shared-lib-calls-exit /usr/lib64/libags.so.0.0.7 exit@GLIBC_2.2.5 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libgmp.so.10 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libuuid.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/librt.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_audio.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgdk_pixbuf-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libgio-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libfontconfig.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libfreetype.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/librt.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_gui.so.0.0.7 /lib64/libpthread.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libuuid.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libxml2.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libags_thread.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/librt.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libm.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_server.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libuuid.so.1 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libgmodule-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libgthread-2.0.so.0 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libm.so.6 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libdl.so.2 gsequencer.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libags_thread.so.0.0.7 /lib64/libX11.so.6 gsequencer.x86_64: W: devel-file-in-non-devel-package /usr/lib64/gsequencer/libgsequencer.so gsequencer-devel.x86_64: W: only-non-binary-in-usr-lib gsequencer-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 43 warnings. ---> Can anything be done to address these issues? It will be good to get this fixed Requires -------- gsequencer (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libX11.so.6()(64bit) libags.so.0()(64bit) libags_audio.so.0()(64bit) libags_gui.so.0()(64bit) libags_server.so.0()(64bit) libags_thread.so.0()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgmp.so.10()(64bit) libgobject-2.0.so.0()(64bit) libgsequencer.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinstpatch-1.0.so.0()(64bit) libjack.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsamplerate.so.0()(64bit) libsamplerate.so.0(libsamplerate.so.0.0)(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libuuid.so.1(UUID_2.20)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) xml-common gsequencer-devel-doc (rpmlib, GLIBC filtered): gsequencer-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gsequencer(x86-64) libags.so.0()(64bit) libags_audio.so.0()(64bit) libags_gui.so.0()(64bit) libags_server.so.0()(64bit) libags_thread.so.0()(64bit) pkgconfig(alsa) pkgconfig(cairo) pkgconfig(fontconfig) pkgconfig(gdk-pixbuf-2.0) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gmodule-2.0) pkgconfig(gobject-2.0) pkgconfig(gthread-2.0) pkgconfig(gtk+-2.0) pkgconfig(jack) pkgconfig(libags) pkgconfig(libinstpatch-1.0) pkgconfig(libxml-2.0) pkgconfig(sndfile) pkgconfig(uuid) gsequencer-debuginfo (rpmlib, GLIBC filtered): Provides -------- gsequencer: application() application(gsequencer.desktop) gsequencer gsequencer(x86-64) libags.so.0()(64bit) libags_audio.so.0()(64bit) libags_gui.so.0()(64bit) libags_server.so.0()(64bit) libags_thread.so.0()(64bit) libgsequencer.so.0()(64bit) gsequencer-devel-doc: gsequencer-devel-doc gsequencer-devel-doc(x86-64) gsequencer-devel: gsequencer-devel gsequencer-devel(x86-64) pkgconfig(libags) pkgconfig(libags_audio) pkgconfig(libags_gui) gsequencer-debuginfo: gsequencer-debuginfo gsequencer-debuginfo(x86-64) Unversioned so-files -------------------- gsequencer: /usr/lib64/gsequencer/libgsequencer.so Source checksums ---------------- http://download.savannah.gnu.org/releases/gsequencer/stable/gsequencer-0.7.122.6.tar.gz : CHECKSUM(SHA256) this package : 6947fc068037aa6b7ed33aa7535776f9ae647754ed2546a68083754fe93b7985 CHECKSUM(SHA256) upstream package : 6947fc068037aa6b7ed33aa7535776f9ae647754ed2546a68083754fe93b7985 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1403417 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx