[Bug 1403417] Review Request: gsequencer - audio processing engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #25 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #24)
> > 3/ from the %files section
> > 
> > %{_bindir}/*
> > %{_mandir}/man1/*
> >
> > 
> > This is a no-no. This package simply cannot own all packages
> > under /usr/bin and /usr/share/man.
> 
> As I've never before seen such a piece of advice, let me point out you're
> wrong here, because basically, this package MUST own all files under
> %_bindir and %_mandir/man1. The file ownership guidelines explain that.
> 

Well, more precisely, a package MUST own all the packages IT CREATES. In other
words, it's my opinion that it is much better to explicitly specify the files
(a point you have also alludedto later) when the list is not too big. Further,
as long as it is not too cumbersome, listing out the files explicitly also
helps in  keeping close track of what is changing in a package.

I agree I should have been much clearer in what I was trying to say.

> 
> So, it has not been a mistake to do that. However, spelling out a bit the
> files to include can be beneficial, because then the %files sections serve
> as helpful file-existance checks, whereas a simple %_bindir/* wildcard would
> not ensure that /usr/bin/gsequencer exists in the package actually. Further,
> if you want to distribute files to multiple subpackages, using only '*'
> could lead to problems as you would need to explicitly %exclude files you
> want to include in other subpackages.

In fact, this is what I should have written in the first place.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]