https://bugzilla.redhat.com/show_bug.cgi?id=1426994 --- Comment #3 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi Tonet, Thank you for the fixes, the package looks better now! There are still a few fixes left that we need to go through to get this review approved! 1 - The licence file is being duplicated during your install process. Remove the one in %{_libdir}/rhythmbox/plugins/alternative-toolbar/LICENSE in the end of the install process and just replace it with %licence LICENSE 2 - when you set a prefix for autogen, you can replace /usr with our macro %{_prefix} 3 - There are some files listed twice, as you can see in your build log. Note that in the %files section, whenever you list a directory, everything inside that directory is automatically included. So, after including %{_datadir}/rhythmbox/plugins/alternative-toolbar You don't need to include other things in there, like %{_datadir}/rhythmbox/plugins/alternative-toolbar/ui/ %{_datadir}/rhythmbox/plugins/alternative-toolbar/img/ 4 - About the comments on the ExcludeArch, since rpmlint complains about it and we do not have any binaries in your package, I believe it would be better to have a noarch package here, what do you think? So, change the ExcludeArch for BuildArch: noarch I am sorry for this last one :) 5 - Changing v0.17.3 for v%{version} in the Source0 string will help you with updates in the future. Let me know if you need help with these. I went through my whole checklist this time, so as soon as you address all these points, I will approve the package! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx