https://bugzilla.redhat.com/show_bug.cgi?id=1424890 --- Comment #2 from Per Bothner <per@xxxxxxxxxxx> --- Thanks for the comments! I made a number of fixes, available at: Spec URL: http://per.bothner.com/DomTerm/domterm.spec SRPM URL: http://per.bothner.com/DomTerm/domterm-0.72-1.fc25.src.rpm - Fixed DomTerm to use the version number in configure.ac. - Added %license entries to %files - BuildRequires: qt5-qtbase-devel qt5-qtwebchannel-devel qt5-qtwebengine-devel These seem to be needed; otherwise fedpkg mockbuild doesn't work. - Used pkgconfig in BuildRequires. - Removed 'rm -rf $RPM_BUILD_ROOT' from %install. - Removed bogus echo command. - Added '%dir %{_datadir}/domterm' to %files. - Changed man page netries in %files to use ildcards. There is still some confusion between "domterm" vs "DomTerm". I could change the package name to DomTerm (and maybe qtDomTerm ?), to match the git name (on GitHub), and that might be easiest. However, I have no problems calling the package "domterm" if that doesn't cause problems. I'm also unsure how I should specify %Source0. I haven't managed to get working automatic downloads from GitHub - if that is actually desirable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx