https://bugzilla.redhat.com/show_bug.cgi?id=1424890 terrycloth <andrew@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@xxxxxxx --- Comment #3 from terrycloth <andrew@xxxxxxx> --- (In reply to Per Bothner from comment #2) > There is still some confusion between "domterm" vs "DomTerm". > I could change the package name to DomTerm (and maybe qtDomTerm ?), > to match the git name (on GitHub), and that might be easiest. > However, I have no problems calling the package "domterm" if > that doesn't cause problems. All lower case is definitely more common for the package name and executable file name. Your spec uses lower case everywhere except where capitalization is hard-coded into the GitHub repo and the tarball directory, so maybe you've already fixed this issue? `fedpkg --release f25 mockbuild` works fine for me. > I'm also unsure how I should specify %Source0. I haven't managed to get > working automatic downloads from GitHub - if that is actually desirable. When you have the correct Source0 URL, it lets spectool and various other packaging tools fetch the source tarball for you. Maybe not a huge deal if you don't, but I think it's convenient enough to be worth using the correct macro for the source URL. And it's actually pretty simple. When I went to your GitHub repo's releases page, I noticed the version 0.72 release could be downloaded at this URL: https://github.com/PerBothner/DomTerm/archive/0.72.tar.gz All you have to do is replace the version number -- 0.72 -- with the version macro. Thus, the Source0 URL you want would look like this: https://github.com/PerBothner/DomTerm/archive/%{version}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx