[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Note I had some problems with "domterm" vs "DomTerm".
> For example the command 'fedpkg --release f25 mockbuild' didn't
> work because it looks for DomTerm-0.71-1.fc25.src.rpm. 

fedpkg mockbuild works within distgit. No idea how you've used it to test-build
a separate src.rpm.

About upper-case vs. mixed cased: 
https://fedoraproject.org/wiki/Packaging:Naming#Case_Sensitivity


> Version:        0.71

Build output preprocessor definitions refers to version "0.50", because that's
what configure.ac defines.


> License:        BSD

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text


> BuildRequires:  qt5-qtbase-devel qt5-qtwebchannel-devel qt5-qtwebengine-devel

Notice the following very useful "SHOULD" item in the guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_based_on_pkg-config


> %package -n qtdomterm
> Requires:  qt5-qtbase qt5-qtwebchannel qt5-qtwebengine

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


> %install
> rm -rf $RPM_BUILD_ROOT

https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections


> # Let alternatives manage the symlink
> echo after install link %{buildroot}%{_bindir}/domterm

Make it a comment instead. Nobody will see this echo output.


> %files
> %{_bindir}/ldomterm
> %{_datadir}/domterm/application.ini
> %{_datadir}/domterm/chrome.manifest
> %{_datadir}/domterm/defaults/preferences/prefs.js

As long as RPM does not include directories automatically, you must specify
every directory you want to be included in the package. Either with explicit
%dir entries or by including entire directory trees:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories


> %{_mandir}/man1/domterm.1.gz
> %{_mandir}/man1/ldomterm.1.gz

As rpmbuild compresses manual pages on-the-fly, changes to the global/local
configuration could change the compression program or disable compression.
That's why a growing number of packagers use wildcards to include manual pages
with any extension:

  %{_mandir}/man1/domterm.1*
  %{_mandir}/man1/ldomterm.1*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]