https://bugzilla.redhat.com/show_bug.cgi?id=1422714 --- Comment #7 from Nemanja Milosevic <nmilosev@xxxxxxxxxxxxxxxxx> --- (In reply to Ralf Corsepius from comment #6) > * Why are you disabling debuginfo? > .. > %global debug_package %{nil} > .. > This in general is not helpful and therefore is not allowed. Please remove > it. > > * Renaming binaries breaks debuginfo - Is this why you are disabling > debuginfos? > Yes, that's why I did it. In the Makefile there was a install -s which stripped the information, so I wrote a patch to allow debuginfo to be generated. > You probably need to rename the program's name to be compiled (ie. to > change/patch the Makefile and change the program's name there) > Wrote a patch for this too, spec file is much cleaner now. :) > > * The package does not use automake > Please remove BuildRequires: automake > Oops, didn't notice that one, thank you! > * Building doesn't honor RPM_OPT_FLAGS. > Please append CFLAGS=${RPM_OPT_FLAGS} to %make_build > Sorry, didn't know about this. It's in a separate wiki page on the Packaging guidelines. Added now. > > * The SOURCE0-URL is better written this way: > Source0: %{url}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz > > Retrieving the package under this URL then will create a tarball named > yank-0.8.0.tar.gz tarball and "v0.8.0.tar.gz" Also added, thank you, didn't know you can do this! :) New spec file: https://pagure.io/yank-rpm/raw/makebuild/f/yank.spec New COPR build: https://copr.fedorainfracloud.org/coprs/nmilosev/yank/build/512925/ New SRPM: https://copr-be.cloud.fedoraproject.org/results/nmilosev/yank/fedora-25-x86_64/00512925-yank/yank-0.8.0-1.fc25.src.rpm Thank you so much for the review! Cheers, Nemanja -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx