[Bug 1403600] Review Request: YafaRay - A free open-source raytracing render engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1403600



--- Comment #17 from Simone Caronni <negativo17@xxxxxxxxx> ---
There are many things to fix here. You have to remove the line:

%{_libdir}/%{yname}_v3_interface.py*

from the files section to make it build.

YafaRay.src: W: spelling-error Summary(en_US) raytracing -> ray tracing,
ray-tracing, retracing
YafaRay.src: W: spelling-error %description -l en_US raytracing -> ray tracing,
ray-tracing, retracing
YafaRay.src: W: spelling-error %description -l en_US Raytracing -> Ray tracing,
Ray-tracing, Retracing

Please adjust to one of the suggestions.

YafaRay.src: W: invalid-license LGPLv2.1

This should be: LGPLv2+

http://fedoraproject.org/wiki/Licensing:Main#Software_License_List

YafaRay.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 23)

Please use spaces everywhere in the SPEC file.

YafaRay.x86_64: W: devel-file-in-non-devel-package
/usr/include/yafaray/core_api/shader.h
YafaRay.x86_64: W: devel-file-in-non-devel-package
/usr/include/yafaray/materials/blendmat.h
[...]

All the headers should be in a separate package.

YafaRay.x86_64: E: script-without-shebang /usr/share/licenses/YafaRay/LICENSES
YafaRay.x86_64: E: incorrect-fsf-address /usr/share/licenses/YafaRay/LICENSES
YafaRay.x86_64: W: spurious-executable-perm /usr/share/doc/YafaRay/AUTHORS
YafaRay.x86_64: W: spurious-executable-perm /usr/share/doc/YafaRay/README
YafaRay-blender.x86_64: W: spurious-executable-perm
/usr/share/doc/YafaRay-blender/README

Make sure all the docs have sane permissions (644).

YafaRay-debuginfo.x86_64: W: invalid-license LGPLv2.1

You can omit the license here, as the blender subpackage depends on the main
package, so the license is installed anyway.

YafaRay-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/Core-22f0ac8f5705416ce7f401c4c15c2d3eb80ad51b/src/yafraycore/imagehandler.cc
YafaRay-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/Core-22f0ac8f5705416ce7f401c4c15c2d3eb80ad51b/src/integrators/bidirpath.cc
YafaRay-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/Core-22f0ac8f5705416ce7f401c4c15c2d3eb80ad51b/include/cameras/orthographicCamera.h
YafaRay-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/Core-22f0ac8f5705416ce7f401c4c15c2d3eb80ad51b/include/utilities/curveUtils.h
[...]

All the source files should be 644, not executables.
You can fix with a couple of finds in the %prep section:

find . -name "*.h" -exec chmod 644 {} \;
find . -name "*.c" -exec chmod 644 {} \;
find . -name "*.cc" -exec chmod 644 {} \;

Ecc..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]