https://bugzilla.redhat.com/show_bug.cgi?id=1422714 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #6 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- * Why are you disabling debuginfo? .. %global debug_package %{nil} .. This in general is not helpful and therefore is not allowed. Please remove it. * Renaming binaries breaks debuginfo - Is this why you are disabling debuginfos? You probably need to rename the program's name to be compiled (ie. to change/patch the Makefile and change the program's name there) * The package does not use automake Please remove BuildRequires: automake * Building doesn't honor RPM_OPT_FLAGS. Please append CFLAGS=${RPM_OPT_FLAGS} to %make_build * The SOURCE0-URL is better written this way: Source0: %{url}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz Retrieving the package under this URL then will create a tarball named yank-0.8.0.tar.gz tarball and "v0.8.0.tar.gz" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx