https://bugzilla.redhat.com/show_bug.cgi?id=1392599 --- Comment #3 from srakitnican <samuel.rakitnican@xxxxxxxxx> --- Thank you for you review and pointers, couple of issues are not clear to me on what to do about. (In reply to Jared Wallace from comment #2) > Issues > ============== > > 1) *MUST* The description has lines exceeding 79 characters. Please split > them across multiple lines to avoid this. > > 2) *MUST* The README.txt has incorrect end-of-line encoding. You can fix > this with the following command: > > sed -i 's/\r$//' README.txt > > 3) *SHOULD* Consider writing a manpage for this so people understand how to > use it. Here's a guide: > http://www.schweikhardt.net/man_page_howto.html > I don't feel comfortable writing man page right now, maybe at some point. > 4) *SHOULD* The link you have to the spec file is not linked to the "raw" > spec file, but rather the Git page - it's better to link to the raw version. > That way when people click to save the link, they get the spec file and not > HTML. > > 5) *SHOULD* You do not need the line "rm -rf %{buildroot}" > > 6) *OPTIONAL* Consider using copr to build this as outlined here: > https://fedoraproject.org/wiki/ > Join_the_package_collection_maintainers#Make_a_Package > It is build using copr as it can be found here: https://copr.fedorainfracloud.org/coprs/srakitnican/minecraft/ > 7) *MUST* The source file mcrcon.c in your src rpm and the upstream source > are different. I suspect because the source url you have is for SourceForge, > and not the upstream github repo, which is here: > https://github.com/Tiiffi/mcrcon > I haven't noticed that. Beside different line endings, the differences are in two lines of comments. --- /tmp/github-mcrcon.c 2016-11-12 10:04:36.309383200 +0100 +++ /tmp/sourceforge-mcrcon.c 2012-08-31 00:07:06.000000000 +0200 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012-2013, Tiiffi <tiiffi -> gmail_dot_com> + * Copyright (c) 2012, Tiiffi <tiiffi_at_gmail_dot_com> * * This software is provided 'as-is', without any express or implied * warranty. In no event will the authors be held liable for any damages @@ -62,7 +62,7 @@ * - Program makes use of C99 feature (variable-length arrays) so "-std=gnu99" flag on * GCC-compiler must be used to avoid unecessary warnings. * - * - Rcon receive buffer is now bigger (2024 bytes -> 10240 bytes). + * - Rcon receive buffer is now bigger (2048 bytes -> 10240 bytes). * * Thanks to 'gman_ftw' @ Bukkit forums. * * - Fixed invalid error message when receiving empty rcon packet (10 bytes). I am not sure what to do about this. I am linking to sourceforge sources in spec file and to a release while github sources does not have releases AFAICT. Should I use snapshot from github? > Everything else seems to be alright. Good luck :) > -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx